Re: [PATCH v3] PCI: aardvark: Don't touch PCIe registers if no card connected

2020-07-21 Thread Lorenzo Pieralisi
On Tue, Jul 21, 2020 at 10:57:13AM +0200, Pali Rohár wrote: > On Wednesday 15 July 2020 17:21:08 Lorenzo Pieralisi wrote: > > On Wed, Jul 15, 2020 at 02:17:26PM +0200, Pali Rohár wrote: > > > On Monday 13 July 2020 12:23:25 Lorenzo Pieralisi wrote: > > > > On Mon, Jul 13, 2020 at 10:27:47AM +0200,

Re: [PATCH v3] PCI: aardvark: Don't touch PCIe registers if no card connected

2020-07-21 Thread Pali Rohár
On Wednesday 15 July 2020 17:21:08 Lorenzo Pieralisi wrote: > On Wed, Jul 15, 2020 at 02:17:26PM +0200, Pali Rohár wrote: > > On Monday 13 July 2020 12:23:25 Lorenzo Pieralisi wrote: > > > On Mon, Jul 13, 2020 at 10:27:47AM +0200, Pali Rohár wrote: > > > > On Friday 10 July 2020 10:18:00 Lorenzo

Re: [PATCH v3] PCI: aardvark: Don't touch PCIe registers if no card connected

2020-07-15 Thread Lorenzo Pieralisi
On Wed, Jul 15, 2020 at 02:17:26PM +0200, Pali Rohár wrote: > On Monday 13 July 2020 12:23:25 Lorenzo Pieralisi wrote: > > On Mon, Jul 13, 2020 at 10:27:47AM +0200, Pali Rohár wrote: > > > On Friday 10 July 2020 10:18:00 Lorenzo Pieralisi wrote: > > > > On Thu, Jul 09, 2020 at 05:09:59PM +0200,

Re: [PATCH v3] PCI: aardvark: Don't touch PCIe registers if no card connected

2020-07-15 Thread Pali Rohár
On Monday 13 July 2020 12:23:25 Lorenzo Pieralisi wrote: > On Mon, Jul 13, 2020 at 10:27:47AM +0200, Pali Rohár wrote: > > On Friday 10 July 2020 10:18:00 Lorenzo Pieralisi wrote: > > > On Thu, Jul 09, 2020 at 05:09:59PM +0200, Pali Rohár wrote: > > > > > I understand that but the bridge bus

Re: [PATCH v3] PCI: aardvark: Don't touch PCIe registers if no card connected

2020-07-14 Thread Pali Rohár
On Monday 13 July 2020 17:41:40 Lorenzo Pieralisi wrote: > On Mon, Jul 13, 2020 at 04:50:03PM +0200, Pali Rohár wrote: > > On Monday 13 July 2020 12:23:25 Lorenzo Pieralisi wrote: > > > I will go over the thread again but I suspect I can merge the patch even > > > though I still believe there is

Re: [PATCH v3] PCI: aardvark: Don't touch PCIe registers if no card connected

2020-07-13 Thread Lorenzo Pieralisi
On Mon, Jul 13, 2020 at 04:50:03PM +0200, Pali Rohár wrote: > On Monday 13 July 2020 12:23:25 Lorenzo Pieralisi wrote: > > I will go over the thread again but I suspect I can merge the patch even > > though I still believe there is work to be done to understand the issue > > we are facing. > >

Re: [PATCH v3] PCI: aardvark: Don't touch PCIe registers if no card connected

2020-07-13 Thread Pali Rohár
On Monday 13 July 2020 12:23:25 Lorenzo Pieralisi wrote: > I will go over the thread again but I suspect I can merge the patch even > though I still believe there is work to be done to understand the issue > we are facing. Just to note that pci-mvebu.c also checks if pcie link is up before trying

Re: [PATCH v3] PCI: aardvark: Don't touch PCIe registers if no card connected

2020-07-13 Thread Lorenzo Pieralisi
On Mon, Jul 13, 2020 at 10:27:47AM +0200, Pali Rohár wrote: > On Friday 10 July 2020 10:18:00 Lorenzo Pieralisi wrote: > > On Thu, Jul 09, 2020 at 05:09:59PM +0200, Pali Rohár wrote: > > > > I understand that but the bridge bus resource can be trimmed to just > > > > contain the root bus because

Re: [PATCH v3] PCI: aardvark: Don't touch PCIe registers if no card connected

2020-07-13 Thread Pali Rohár
On Friday 10 July 2020 10:18:00 Lorenzo Pieralisi wrote: > On Thu, Jul 09, 2020 at 05:09:59PM +0200, Pali Rohár wrote: > > > I understand that but the bridge bus resource can be trimmed to just > > > contain the root bus because that's the only one where there is a > > > chance you can enumerate a

Re: [PATCH v3] PCI: aardvark: Don't touch PCIe registers if no card connected

2020-07-10 Thread Bjorn Helgaas
On Fri, Jul 10, 2020 at 09:30:03PM +0200, Pali Rohár wrote: > On Friday 10 July 2020 11:08:28 Bjorn Helgaas wrote: > > On Fri, Jul 10, 2020 at 05:44:58PM +0200, Pali Rohár wrote: > > > I can reproduce following issue: Connect Compex WLE900VX card, configure > > > aardvark to gen2 mode. And then

Re: [PATCH v3] PCI: aardvark: Don't touch PCIe registers if no card connected

2020-07-10 Thread Pali Rohár
On Friday 10 July 2020 11:08:28 Bjorn Helgaas wrote: > On Fri, Jul 10, 2020 at 05:44:58PM +0200, Pali Rohár wrote: > > I can reproduce following issue: Connect Compex WLE900VX card, configure > > aardvark to gen2 mode. And then card is detected only after the first > > link training. If kernel

Re: [PATCH v3] PCI: aardvark: Don't touch PCIe registers if no card connected

2020-07-10 Thread Bjorn Helgaas
On Fri, Jul 10, 2020 at 05:44:58PM +0200, Pali Rohár wrote: > I can reproduce following issue: Connect Compex WLE900VX card, configure > aardvark to gen2 mode. And then card is detected only after the first > link training. If kernel tries to retrain link again (e.g. via ASPM > code) then card is

Re: [PATCH v3] PCI: aardvark: Don't touch PCIe registers if no card connected

2020-07-10 Thread Pali Rohár
On Friday 10 July 2020 10:18:00 Lorenzo Pieralisi wrote: > I would be very grateful if you could describe what happens in HW > when these conditions trigger - I would like to understand if this > issue is aardvark specific or it isn't. Hello Lorenzo! We are not sure what is the problem and where

Re: [PATCH v3] PCI: aardvark: Don't touch PCIe registers if no card connected

2020-07-10 Thread Lorenzo Pieralisi
On Thu, Jul 09, 2020 at 05:09:59PM +0200, Pali Rohár wrote: [...] > > I understand that but the bridge bus resource can be trimmed to just > > contain the root bus because that's the only one where there is a > > chance you can enumerate a device. > > It is possible to register only root bridge

Re: [PATCH v3] PCI: aardvark: Don't touch PCIe registers if no card connected

2020-07-09 Thread Pali Rohár
On Thursday 09 July 2020 15:47:01 Lorenzo Pieralisi wrote: > On Thu, Jul 09, 2020 at 02:22:08PM +0200, Pali Rohár wrote: > > On Thursday 09 July 2020 12:35:09 Lorenzo Pieralisi wrote: > > > On Thu, Jul 02, 2020 at 10:30:36AM +0200, Pali Rohár wrote: > > > > When there is no PCIe card connected and

Re: [PATCH v3] PCI: aardvark: Don't touch PCIe registers if no card connected

2020-07-09 Thread Lorenzo Pieralisi
On Thu, Jul 09, 2020 at 02:22:08PM +0200, Pali Rohár wrote: > On Thursday 09 July 2020 12:35:09 Lorenzo Pieralisi wrote: > > On Thu, Jul 02, 2020 at 10:30:36AM +0200, Pali Rohár wrote: > > > When there is no PCIe card connected and advk_pcie_rd_conf() or > > > advk_pcie_wr_conf() is called for PCI

Re: [PATCH v3] PCI: aardvark: Don't touch PCIe registers if no card connected

2020-07-09 Thread Pali Rohár
On Thursday 09 July 2020 12:35:09 Lorenzo Pieralisi wrote: > On Thu, Jul 02, 2020 at 10:30:36AM +0200, Pali Rohár wrote: > > When there is no PCIe card connected and advk_pcie_rd_conf() or > > advk_pcie_wr_conf() is called for PCI bus which doesn't belong to emulated > > root bridge, the aardvark

Re: [PATCH v3] PCI: aardvark: Don't touch PCIe registers if no card connected

2020-07-09 Thread Lorenzo Pieralisi
On Thu, Jul 02, 2020 at 10:30:36AM +0200, Pali Rohár wrote: > When there is no PCIe card connected and advk_pcie_rd_conf() or > advk_pcie_wr_conf() is called for PCI bus which doesn't belong to emulated > root bridge, the aardvark driver throws the following error message: > > advk-pcie

[PATCH v3] PCI: aardvark: Don't touch PCIe registers if no card connected

2020-07-02 Thread Pali Rohár
When there is no PCIe card connected and advk_pcie_rd_conf() or advk_pcie_wr_conf() is called for PCI bus which doesn't belong to emulated root bridge, the aardvark driver throws the following error message: advk-pcie d007.pcie: config read/write timed out Obviously accessing PCIe