Re: [PATCH v3] PCI: rework new_id interface for known vendor/device values

2014-06-15 Thread Konstantin Khlebnikov
On Wed, Apr 30, 2014 at 3:41 AM, Bjorn Helgaas wrote: > On Tue, Apr 01, 2014 at 09:32:59PM -0400, Bandan Das wrote: >> >> While using the new_id interface, the user can unintentionally feed >> incorrect values if the driver static table has a matching entry. >> This is possible since only the

Re: [PATCH v3] PCI: rework new_id interface for known vendor/device values

2014-06-15 Thread Konstantin Khlebnikov
On Wed, Apr 30, 2014 at 3:41 AM, Bjorn Helgaas bhelg...@google.com wrote: On Tue, Apr 01, 2014 at 09:32:59PM -0400, Bandan Das wrote: While using the new_id interface, the user can unintentionally feed incorrect values if the driver static table has a matching entry. This is possible since

Re: [PATCH v3] PCI: rework new_id interface for known vendor/device values

2014-04-29 Thread Bjorn Helgaas
On Tue, Apr 01, 2014 at 09:32:59PM -0400, Bandan Das wrote: > > While using the new_id interface, the user can unintentionally feed > incorrect values if the driver static table has a matching entry. > This is possible since only the device and vendor fields are > mandatory and the rest are

Re: [PATCH v3] PCI: rework new_id interface for known vendor/device values

2014-04-29 Thread Bjorn Helgaas
On Tue, Apr 01, 2014 at 09:32:59PM -0400, Bandan Das wrote: While using the new_id interface, the user can unintentionally feed incorrect values if the driver static table has a matching entry. This is possible since only the device and vendor fields are mandatory and the rest are optional.

Re: [PATCH v3] PCI: rework new_id interface for known vendor/device values

2014-04-28 Thread Bjorn Helgaas
On Fri, Apr 25, 2014 at 01:51:50PM -0400, Bandan Das wrote: > Bjorn Helgaas writes: > > > On Tue, Apr 01, 2014 at 09:32:59PM -0400, Bandan Das wrote: > >> > >> While using the new_id interface, the user can unintentionally feed > >> incorrect values if the driver static table has a matching

Re: [PATCH v3] PCI: rework new_id interface for known vendor/device values

2014-04-28 Thread Bjorn Helgaas
On Fri, Apr 25, 2014 at 11:39:36AM -0600, Alex Williamson wrote: > On Thu, 2014-04-24 at 16:45 -0600, Bjorn Helgaas wrote: > > On Tue, Apr 01, 2014 at 09:32:59PM -0400, Bandan Das wrote: > > > > > > While using the new_id interface, the user can unintentionally feed > > > incorrect values if the

Re: [PATCH v3] PCI: rework new_id interface for known vendor/device values

2014-04-28 Thread Bjorn Helgaas
On Fri, Apr 25, 2014 at 11:39:36AM -0600, Alex Williamson wrote: On Thu, 2014-04-24 at 16:45 -0600, Bjorn Helgaas wrote: On Tue, Apr 01, 2014 at 09:32:59PM -0400, Bandan Das wrote: While using the new_id interface, the user can unintentionally feed incorrect values if the driver

Re: [PATCH v3] PCI: rework new_id interface for known vendor/device values

2014-04-28 Thread Bjorn Helgaas
On Fri, Apr 25, 2014 at 01:51:50PM -0400, Bandan Das wrote: Bjorn Helgaas bhelg...@google.com writes: On Tue, Apr 01, 2014 at 09:32:59PM -0400, Bandan Das wrote: While using the new_id interface, the user can unintentionally feed incorrect values if the driver static table has a

Re: [PATCH v3] PCI: rework new_id interface for known vendor/device values

2014-04-25 Thread Bandan Das
Bjorn Helgaas writes: > On Tue, Apr 01, 2014 at 09:32:59PM -0400, Bandan Das wrote: >> >> While using the new_id interface, the user can unintentionally feed >> incorrect values if the driver static table has a matching entry. >> This is possible since only the device and vendor fields are >>

Re: [PATCH v3] PCI: rework new_id interface for known vendor/device values

2014-04-25 Thread Alex Williamson
On Thu, 2014-04-24 at 16:45 -0600, Bjorn Helgaas wrote: > On Tue, Apr 01, 2014 at 09:32:59PM -0400, Bandan Das wrote: > > > > While using the new_id interface, the user can unintentionally feed > > incorrect values if the driver static table has a matching entry. > > This is possible since only

Re: [PATCH v3] PCI: rework new_id interface for known vendor/device values

2014-04-25 Thread Alex Williamson
On Thu, 2014-04-24 at 16:45 -0600, Bjorn Helgaas wrote: On Tue, Apr 01, 2014 at 09:32:59PM -0400, Bandan Das wrote: While using the new_id interface, the user can unintentionally feed incorrect values if the driver static table has a matching entry. This is possible since only the device

Re: [PATCH v3] PCI: rework new_id interface for known vendor/device values

2014-04-25 Thread Bandan Das
Bjorn Helgaas bhelg...@google.com writes: On Tue, Apr 01, 2014 at 09:32:59PM -0400, Bandan Das wrote: While using the new_id interface, the user can unintentionally feed incorrect values if the driver static table has a matching entry. This is possible since only the device and vendor

Re: [PATCH v3] PCI: rework new_id interface for known vendor/device values

2014-04-24 Thread Bjorn Helgaas
On Tue, Apr 01, 2014 at 09:32:59PM -0400, Bandan Das wrote: > > While using the new_id interface, the user can unintentionally feed > incorrect values if the driver static table has a matching entry. > This is possible since only the device and vendor fields are > mandatory and the rest are

Re: [PATCH v3] PCI: rework new_id interface for known vendor/device values

2014-04-24 Thread Bjorn Helgaas
On Tue, Apr 01, 2014 at 09:32:59PM -0400, Bandan Das wrote: While using the new_id interface, the user can unintentionally feed incorrect values if the driver static table has a matching entry. This is possible since only the device and vendor fields are mandatory and the rest are optional.

Re: [PATCH v3] PCI: rework new_id interface for known vendor/device values

2014-04-01 Thread Alex Williamson
On Tue, 2014-04-01 at 21:32 -0400, Bandan Das wrote: > While using the new_id interface, the user can unintentionally feed > incorrect values if the driver static table has a matching entry. > This is possible since only the device and vendor fields are > mandatory and the rest are optional. As a

[PATCH v3] PCI: rework new_id interface for known vendor/device values

2014-04-01 Thread Bandan Das
While using the new_id interface, the user can unintentionally feed incorrect values if the driver static table has a matching entry. This is possible since only the device and vendor fields are mandatory and the rest are optional. As a result, store_new_id will fill in default values that are

[PATCH v3] PCI: rework new_id interface for known vendor/device values

2014-04-01 Thread Bandan Das
While using the new_id interface, the user can unintentionally feed incorrect values if the driver static table has a matching entry. This is possible since only the device and vendor fields are mandatory and the rest are optional. As a result, store_new_id will fill in default values that are

Re: [PATCH v3] PCI: rework new_id interface for known vendor/device values

2014-04-01 Thread Alex Williamson
On Tue, 2014-04-01 at 21:32 -0400, Bandan Das wrote: While using the new_id interface, the user can unintentionally feed incorrect values if the driver static table has a matching entry. This is possible since only the device and vendor fields are mandatory and the rest are optional. As a