Re: [PATCH v3] RDMA/umem: minor bug fix in error handling path

2019-03-05 Thread Leon Romanovsky
On Tue, Mar 05, 2019 at 05:04:06PM +0200, Yuval Shaia wrote: > On Mon, Mar 04, 2019 at 03:58:15AM -0800, Ira Weiny wrote: > > On Mon, Mar 04, 2019 at 11:46:45AM -0800, john.hubb...@gmail.com wrote: > > > From: John Hubbard > > > > > > 1. Bug fix: fix an off by one error in the code that > > > clea

Re: [PATCH v3] RDMA/umem: minor bug fix in error handling path

2019-03-05 Thread Yuval Shaia
On Mon, Mar 04, 2019 at 03:58:15AM -0800, Ira Weiny wrote: > On Mon, Mar 04, 2019 at 11:46:45AM -0800, john.hubb...@gmail.com wrote: > > From: John Hubbard > > > > 1. Bug fix: fix an off by one error in the code that > > cleans up if it fails to dma-map a page, after having > > done a get_user_pa

Re: [PATCH v3] RDMA/umem: minor bug fix in error handling path

2019-03-04 Thread Jason Gunthorpe
On Mon, Mar 04, 2019 at 11:46:45AM -0800, john.hubb...@gmail.com wrote: > From: John Hubbard > > 1. Bug fix: fix an off by one error in the code that > cleans up if it fails to dma-map a page, after having > done a get_user_pages_remote() on a range of pages. > > 2. Refinement: for that same cle

Re: [PATCH v3] RDMA/umem: minor bug fix in error handling path

2019-03-04 Thread Ira Weiny
On Mon, Mar 04, 2019 at 11:46:45AM -0800, john.hubb...@gmail.com wrote: > From: John Hubbard > > 1. Bug fix: fix an off by one error in the code that > cleans up if it fails to dma-map a page, after having > done a get_user_pages_remote() on a range of pages. > > 2. Refinement: for that same cle

Re: [PATCH v3] RDMA/umem: minor bug fix in error handling path

2019-03-04 Thread Ira Weiny
On Mon, Mar 04, 2019 at 11:46:45AM -0800, john.hubb...@gmail.com wrote: > From: John Hubbard > > 1. Bug fix: fix an off by one error in the code that > cleans up if it fails to dma-map a page, after having > done a get_user_pages_remote() on a range of pages. > > 2. Refinement: for that same cle

Re: [PATCH v3] RDMA/umem: minor bug fix in error handling path

2019-03-04 Thread Leon Romanovsky
On Mon, Mar 04, 2019 at 11:46:45AM -0800, john.hubb...@gmail.com wrote: > From: John Hubbard > > 1. Bug fix: fix an off by one error in the code that > cleans up if it fails to dma-map a page, after having > done a get_user_pages_remote() on a range of pages. > > 2. Refinement: for that same clean

[PATCH v3] RDMA/umem: minor bug fix in error handling path

2019-03-04 Thread john . hubbard
From: John Hubbard 1. Bug fix: fix an off by one error in the code that cleans up if it fails to dma-map a page, after having done a get_user_pages_remote() on a range of pages. 2. Refinement: for that same cleanup code, release_pages() is better than put_page() in a loop. Cc: Leon Romanovsky