Re: [PATCH v3] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-21 Thread Stefano Stabellini
On Tue, 21 Jan 2014, Will Deacon wrote: > On Mon, Jan 20, 2014 at 03:32:48PM +, Stefano Stabellini wrote: > > On Thu, 16 Jan 2014, Will Deacon wrote: > > > For the xchg part, yes, that looks a lot better. I don't like the #undef > > > CONFIG_CPU_V6 though, can that be rewritten to use

Re: [PATCH v3] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-21 Thread Will Deacon
On Mon, Jan 20, 2014 at 03:32:48PM +, Stefano Stabellini wrote: > On Thu, 16 Jan 2014, Will Deacon wrote: > > For the xchg part, yes, that looks a lot better. I don't like the #undef > > CONFIG_CPU_V6 though, can that be rewritten to use __LINUX_ARM_ARCH__? > > The problem is that the 1 and 2

Re: [PATCH v3] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-21 Thread Will Deacon
On Mon, Jan 20, 2014 at 03:32:48PM +, Stefano Stabellini wrote: On Thu, 16 Jan 2014, Will Deacon wrote: For the xchg part, yes, that looks a lot better. I don't like the #undef CONFIG_CPU_V6 though, can that be rewritten to use __LINUX_ARM_ARCH__? The problem is that the 1 and 2 byte

Re: [PATCH v3] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-21 Thread Stefano Stabellini
On Tue, 21 Jan 2014, Will Deacon wrote: On Mon, Jan 20, 2014 at 03:32:48PM +, Stefano Stabellini wrote: On Thu, 16 Jan 2014, Will Deacon wrote: For the xchg part, yes, that looks a lot better. I don't like the #undef CONFIG_CPU_V6 though, can that be rewritten to use

Re: [PATCH v3] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-20 Thread Stefano Stabellini
On Thu, 16 Jan 2014, Will Deacon wrote: > Hi Stefano, > > On Thu, Jan 16, 2014 at 04:27:55PM +, Stefano Stabellini wrote: > > On Thu, 9 Jan 2014, Will Deacon wrote: > > > Ok, thanks for the explanation. Looking at the patch, I wonder whether > > > it's > > > not cleaner just to implement

Re: [PATCH v3] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-20 Thread Stefano Stabellini
On Thu, 16 Jan 2014, Will Deacon wrote: Hi Stefano, On Thu, Jan 16, 2014 at 04:27:55PM +, Stefano Stabellini wrote: On Thu, 9 Jan 2014, Will Deacon wrote: Ok, thanks for the explanation. Looking at the patch, I wonder whether it's not cleaner just to implement xchg code

Re: [PATCH v3] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-16 Thread Will Deacon
Hi Stefano, On Thu, Jan 16, 2014 at 04:27:55PM +, Stefano Stabellini wrote: > On Thu, 9 Jan 2014, Will Deacon wrote: > > Ok, thanks for the explanation. Looking at the patch, I wonder whether it's > > not cleaner just to implement xchg code separately for Xen? The Linux code > > isn't always

Re: [PATCH v3] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-16 Thread Stefano Stabellini
On Thu, 9 Jan 2014, Will Deacon wrote: > On Thu, Jan 09, 2014 at 12:47:24PM +, Stefano Stabellini wrote: > > On Thu, 9 Jan 2014, Arnd Bergmann wrote: > > > On Thursday 09 January 2014, Will Deacon wrote: > > > > On Wed, Jan 08, 2014 at 06:00:23PM +, Stefano Stabellini wrote: > > > > >

Re: [PATCH v3] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-16 Thread Stefano Stabellini
On Thu, 9 Jan 2014, Will Deacon wrote: On Thu, Jan 09, 2014 at 12:47:24PM +, Stefano Stabellini wrote: On Thu, 9 Jan 2014, Arnd Bergmann wrote: On Thursday 09 January 2014, Will Deacon wrote: On Wed, Jan 08, 2014 at 06:00:23PM +, Stefano Stabellini wrote: Remove

Re: [PATCH v3] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-16 Thread Will Deacon
Hi Stefano, On Thu, Jan 16, 2014 at 04:27:55PM +, Stefano Stabellini wrote: On Thu, 9 Jan 2014, Will Deacon wrote: Ok, thanks for the explanation. Looking at the patch, I wonder whether it's not cleaner just to implement xchg code separately for Xen? The Linux code isn't always

Re: [PATCH v3] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-13 Thread Jaccon Bastiaansen
2014/1/10 Chen Gang F T : > On 01/10/2014 02:42 AM, Will Deacon wrote: >> On Thu, Jan 09, 2014 at 12:47:24PM +, Stefano Stabellini wrote: >>> On Thu, 9 Jan 2014, Arnd Bergmann wrote: On Thursday 09 January 2014, Will Deacon wrote: > On Wed, Jan 08, 2014 at 06:00:23PM +, Stefano

Re: [PATCH v3] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-13 Thread Jaccon Bastiaansen
2014/1/10 Chen Gang F T chen.gang.flying.transfor...@gmail.com: On 01/10/2014 02:42 AM, Will Deacon wrote: On Thu, Jan 09, 2014 at 12:47:24PM +, Stefano Stabellini wrote: On Thu, 9 Jan 2014, Arnd Bergmann wrote: On Thursday 09 January 2014, Will Deacon wrote: On Wed, Jan 08, 2014 at

Re: [PATCH v3] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-10 Thread Chen Gang F T
On 01/10/2014 02:42 AM, Will Deacon wrote: > On Thu, Jan 09, 2014 at 12:47:24PM +, Stefano Stabellini wrote: >> On Thu, 9 Jan 2014, Arnd Bergmann wrote: >>> On Thursday 09 January 2014, Will Deacon wrote: On Wed, Jan 08, 2014 at 06:00:23PM +, Stefano Stabellini wrote: > Remove

Re: [PATCH v3] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-10 Thread Chen Gang F T
On 01/10/2014 02:42 AM, Will Deacon wrote: On Thu, Jan 09, 2014 at 12:47:24PM +, Stefano Stabellini wrote: On Thu, 9 Jan 2014, Arnd Bergmann wrote: On Thursday 09 January 2014, Will Deacon wrote: On Wed, Jan 08, 2014 at 06:00:23PM +, Stefano Stabellini wrote: Remove !GENERIC_ATOMIC64

Re: [PATCH v3] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-09 Thread Will Deacon
On Thu, Jan 09, 2014 at 12:47:24PM +, Stefano Stabellini wrote: > On Thu, 9 Jan 2014, Arnd Bergmann wrote: > > On Thursday 09 January 2014, Will Deacon wrote: > > > On Wed, Jan 08, 2014 at 06:00:23PM +, Stefano Stabellini wrote: > > > > Remove !GENERIC_ATOMIC64 build dependency: > > > > -

Re: [PATCH v3] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-09 Thread Stefano Stabellini
On Thu, 9 Jan 2014, Arnd Bergmann wrote: > On Thursday 09 January 2014, Will Deacon wrote: > > On Wed, Jan 08, 2014 at 06:00:23PM +, Stefano Stabellini wrote: > > > Remove !GENERIC_ATOMIC64 build dependency: > > > - rename atomic64_xchg to armv7_atomic64_xchg and define it even ifdef > > >

Re: [PATCH v3] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-09 Thread Arnd Bergmann
On Thursday 09 January 2014, Will Deacon wrote: > On Wed, Jan 08, 2014 at 06:00:23PM +, Stefano Stabellini wrote: > > Remove !GENERIC_ATOMIC64 build dependency: > > - rename atomic64_xchg to armv7_atomic64_xchg and define it even ifdef > > GENERIC_ATOMIC64; > > - call armv7_atomic64_xchg

Re: [PATCH v3] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-09 Thread Will Deacon
Hi Stefano, On Wed, Jan 08, 2014 at 06:00:23PM +, Stefano Stabellini wrote: > Remove !GENERIC_ATOMIC64 build dependency: > - rename atomic64_xchg to armv7_atomic64_xchg and define it even ifdef > GENERIC_ATOMIC64; > - call armv7_atomic64_xchg directly from xen/events.h. > > Remove !CPU_V6

Re: [PATCH v3] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-09 Thread Will Deacon
Hi Stefano, On Wed, Jan 08, 2014 at 06:00:23PM +, Stefano Stabellini wrote: Remove !GENERIC_ATOMIC64 build dependency: - rename atomic64_xchg to armv7_atomic64_xchg and define it even ifdef GENERIC_ATOMIC64; - call armv7_atomic64_xchg directly from xen/events.h. Remove !CPU_V6 build

Re: [PATCH v3] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-09 Thread Arnd Bergmann
On Thursday 09 January 2014, Will Deacon wrote: On Wed, Jan 08, 2014 at 06:00:23PM +, Stefano Stabellini wrote: Remove !GENERIC_ATOMIC64 build dependency: - rename atomic64_xchg to armv7_atomic64_xchg and define it even ifdef GENERIC_ATOMIC64; - call armv7_atomic64_xchg directly

Re: [PATCH v3] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-09 Thread Stefano Stabellini
On Thu, 9 Jan 2014, Arnd Bergmann wrote: On Thursday 09 January 2014, Will Deacon wrote: On Wed, Jan 08, 2014 at 06:00:23PM +, Stefano Stabellini wrote: Remove !GENERIC_ATOMIC64 build dependency: - rename atomic64_xchg to armv7_atomic64_xchg and define it even ifdef

Re: [PATCH v3] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-09 Thread Will Deacon
On Thu, Jan 09, 2014 at 12:47:24PM +, Stefano Stabellini wrote: On Thu, 9 Jan 2014, Arnd Bergmann wrote: On Thursday 09 January 2014, Will Deacon wrote: On Wed, Jan 08, 2014 at 06:00:23PM +, Stefano Stabellini wrote: Remove !GENERIC_ATOMIC64 build dependency: - rename

[PATCH v3] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-08 Thread Stefano Stabellini
Remove !GENERIC_ATOMIC64 build dependency: - rename atomic64_xchg to armv7_atomic64_xchg and define it even ifdef GENERIC_ATOMIC64; - call armv7_atomic64_xchg directly from xen/events.h. Remove !CPU_V6 build dependency: - introduce __cmpxchg8 and __cmpxchg16, compiled even ifdef

[PATCH v3] arm: remove !CPU_V6 and !GENERIC_ATOMIC64 build dependencies for XEN

2014-01-08 Thread Stefano Stabellini
Remove !GENERIC_ATOMIC64 build dependency: - rename atomic64_xchg to armv7_atomic64_xchg and define it even ifdef GENERIC_ATOMIC64; - call armv7_atomic64_xchg directly from xen/events.h. Remove !CPU_V6 build dependency: - introduce __cmpxchg8 and __cmpxchg16, compiled even ifdef