Re: [PATCH v3] cpuset: Enable cpuset controller in default hierarchy

2017-11-27 Thread Waiman Long
On 11/27/2017 04:42 PM, Tejun Heo wrote: > Hello, Waiman. > > On Mon, Nov 27, 2017 at 04:19:57PM -0500, Waiman Long wrote: >>> Let's start just with [e]cpus and [e]mems. The flags interface looks >>> fine but the implementations of these features are really bad and >>> cgroup2 doesn't migrate

Re: [PATCH v3] cpuset: Enable cpuset controller in default hierarchy

2017-11-27 Thread Waiman Long
On 11/27/2017 04:42 PM, Tejun Heo wrote: > Hello, Waiman. > > On Mon, Nov 27, 2017 at 04:19:57PM -0500, Waiman Long wrote: >>> Let's start just with [e]cpus and [e]mems. The flags interface looks >>> fine but the implementations of these features are really bad and >>> cgroup2 doesn't migrate

Re: [PATCH v3] cpuset: Enable cpuset controller in default hierarchy

2017-11-27 Thread Tejun Heo
Hello, Waiman. On Mon, Nov 27, 2017 at 04:19:57PM -0500, Waiman Long wrote: > > Let's start just with [e]cpus and [e]mems. The flags interface looks > > fine but the implementations of these features are really bad and > > cgroup2 doesn't migrate resources for other controllers either anyway. >

Re: [PATCH v3] cpuset: Enable cpuset controller in default hierarchy

2017-11-27 Thread Tejun Heo
Hello, Waiman. On Mon, Nov 27, 2017 at 04:19:57PM -0500, Waiman Long wrote: > > Let's start just with [e]cpus and [e]mems. The flags interface looks > > fine but the implementations of these features are really bad and > > cgroup2 doesn't migrate resources for other controllers either anyway. >

Re: [PATCH v3] cpuset: Enable cpuset controller in default hierarchy

2017-11-27 Thread Waiman Long
On 11/27/2017 04:04 PM, Tejun Heo wrote: > Hello, Waiman. > > Sorry about the long delay. > > On Fri, Oct 06, 2017 at 05:10:30PM -0400, Waiman Long wrote: >> +Cpuset Interface Files >> +~~ >> + >> + cpuset.cpus >> +A read-write multiple values file which exists on non-root

Re: [PATCH v3] cpuset: Enable cpuset controller in default hierarchy

2017-11-27 Thread Waiman Long
On 11/27/2017 04:04 PM, Tejun Heo wrote: > Hello, Waiman. > > Sorry about the long delay. > > On Fri, Oct 06, 2017 at 05:10:30PM -0400, Waiman Long wrote: >> +Cpuset Interface Files >> +~~ >> + >> + cpuset.cpus >> +A read-write multiple values file which exists on non-root

Re: [PATCH v3] cpuset: Enable cpuset controller in default hierarchy

2017-11-27 Thread Tejun Heo
Hello, Waiman. Sorry about the long delay. On Fri, Oct 06, 2017 at 05:10:30PM -0400, Waiman Long wrote: > +Cpuset Interface Files > +~~ > + > + cpuset.cpus > + A read-write multiple values file which exists on non-root > + cgroups. > + > + It lists the CPUs

Re: [PATCH v3] cpuset: Enable cpuset controller in default hierarchy

2017-11-27 Thread Tejun Heo
Hello, Waiman. Sorry about the long delay. On Fri, Oct 06, 2017 at 05:10:30PM -0400, Waiman Long wrote: > +Cpuset Interface Files > +~~ > + > + cpuset.cpus > + A read-write multiple values file which exists on non-root > + cgroups. > + > + It lists the CPUs

Re: [PATCH v3] cpuset: Enable cpuset controller in default hierarchy

2017-11-14 Thread Waiman Long
On 10/26/2017 02:12 PM, Waiman Long wrote: > On 10/26/2017 10:39 AM, Tejun Heo wrote: >> Hello, Waiman. >> >> On Wed, Oct 25, 2017 at 11:50:34AM -0400, Waiman Long wrote: >>> Ping! Any comment on this patch? >> Sorry about the lack of response. Here are my two thoughts. >> >> 1. I'm not really

Re: [PATCH v3] cpuset: Enable cpuset controller in default hierarchy

2017-11-14 Thread Waiman Long
On 10/26/2017 02:12 PM, Waiman Long wrote: > On 10/26/2017 10:39 AM, Tejun Heo wrote: >> Hello, Waiman. >> >> On Wed, Oct 25, 2017 at 11:50:34AM -0400, Waiman Long wrote: >>> Ping! Any comment on this patch? >> Sorry about the lack of response. Here are my two thoughts. >> >> 1. I'm not really

Re: [PATCH v3] cpuset: Enable cpuset controller in default hierarchy

2017-10-26 Thread Christian Brauner
On Thu, Oct 26, 2017 at 02:12:01PM -0400, Waiman Long wrote: > On 10/26/2017 10:39 AM, Tejun Heo wrote: > > Hello, Waiman. > > > > On Wed, Oct 25, 2017 at 11:50:34AM -0400, Waiman Long wrote: > >> Ping! Any comment on this patch? Fwiw, I just saw this patch today for some weird reason. > > Sorry

Re: [PATCH v3] cpuset: Enable cpuset controller in default hierarchy

2017-10-26 Thread Christian Brauner
On Thu, Oct 26, 2017 at 02:12:01PM -0400, Waiman Long wrote: > On 10/26/2017 10:39 AM, Tejun Heo wrote: > > Hello, Waiman. > > > > On Wed, Oct 25, 2017 at 11:50:34AM -0400, Waiman Long wrote: > >> Ping! Any comment on this patch? Fwiw, I just saw this patch today for some weird reason. > > Sorry

Re: [PATCH v3] cpuset: Enable cpuset controller in default hierarchy

2017-10-26 Thread Waiman Long
On 10/26/2017 10:39 AM, Tejun Heo wrote: > Hello, Waiman. > > On Wed, Oct 25, 2017 at 11:50:34AM -0400, Waiman Long wrote: >> Ping! Any comment on this patch? > Sorry about the lack of response. Here are my two thoughts. > > 1. I'm not really sure about the memory part. Mostly because of the >

Re: [PATCH v3] cpuset: Enable cpuset controller in default hierarchy

2017-10-26 Thread Waiman Long
On 10/26/2017 10:39 AM, Tejun Heo wrote: > Hello, Waiman. > > On Wed, Oct 25, 2017 at 11:50:34AM -0400, Waiman Long wrote: >> Ping! Any comment on this patch? > Sorry about the lack of response. Here are my two thoughts. > > 1. I'm not really sure about the memory part. Mostly because of the >

Re: [PATCH v3] cpuset: Enable cpuset controller in default hierarchy

2017-10-26 Thread Tejun Heo
Hello, Waiman. On Wed, Oct 25, 2017 at 11:50:34AM -0400, Waiman Long wrote: > Ping! Any comment on this patch? Sorry about the lack of response. Here are my two thoughts. 1. I'm not really sure about the memory part. Mostly because of the way it's configured and enforced is completely out

Re: [PATCH v3] cpuset: Enable cpuset controller in default hierarchy

2017-10-26 Thread Tejun Heo
Hello, Waiman. On Wed, Oct 25, 2017 at 11:50:34AM -0400, Waiman Long wrote: > Ping! Any comment on this patch? Sorry about the lack of response. Here are my two thoughts. 1. I'm not really sure about the memory part. Mostly because of the way it's configured and enforced is completely out

Re: [PATCH v3] cpuset: Enable cpuset controller in default hierarchy

2017-10-25 Thread Waiman Long
On 10/06/2017 05:10 PM, Waiman Long wrote: > Given the fact that thread mode had been merged into 4.14, it is now > time to enable cpuset to be used in the default hierarchy (cgroup v2) > as it is clearly threaded. > > The cpuset controller had experienced feature creep since its > introduction

Re: [PATCH v3] cpuset: Enable cpuset controller in default hierarchy

2017-10-25 Thread Waiman Long
On 10/06/2017 05:10 PM, Waiman Long wrote: > Given the fact that thread mode had been merged into 4.14, it is now > time to enable cpuset to be used in the default hierarchy (cgroup v2) > as it is clearly threaded. > > The cpuset controller had experienced feature creep since its > introduction

[PATCH v3] cpuset: Enable cpuset controller in default hierarchy

2017-10-06 Thread Waiman Long
Given the fact that thread mode had been merged into 4.14, it is now time to enable cpuset to be used in the default hierarchy (cgroup v2) as it is clearly threaded. The cpuset controller had experienced feature creep since its introduction more than a decade ago. Besides the core cpus and mems

[PATCH v3] cpuset: Enable cpuset controller in default hierarchy

2017-10-06 Thread Waiman Long
Given the fact that thread mode had been merged into 4.14, it is now time to enable cpuset to be used in the default hierarchy (cgroup v2) as it is clearly threaded. The cpuset controller had experienced feature creep since its introduction more than a decade ago. Besides the core cpus and mems