Re: [PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-07-03 Thread Stuart Hayes
On 7/2/2018 11:15 AM, mario.limoncie...@dell.com wrote: >> >>> I don't believe SMM communication ACPI table has ever been implemented by >> Dell >>> on server or client BIOS. I do agree this table describes the behavior >>> that DCDBAS >> driver >>> has used since before even UEFI BIOS pretty

Re: [PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-07-03 Thread Stuart Hayes
On 7/2/2018 11:15 AM, mario.limoncie...@dell.com wrote: >> >>> I don't believe SMM communication ACPI table has ever been implemented by >> Dell >>> on server or client BIOS. I do agree this table describes the behavior >>> that DCDBAS >> driver >>> has used since before even UEFI BIOS pretty

RE: [PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-07-02 Thread Mario.Limonciello
> > > I don't believe SMM communication ACPI table has ever been implemented by > Dell > > on server or client BIOS. I do agree this table describes the behavior > > that DCDBAS > driver > > has used since before even UEFI BIOS pretty accurately. > > So, EPS table has been for ages in Dell

RE: [PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-07-02 Thread Mario.Limonciello
> > > I don't believe SMM communication ACPI table has ever been implemented by > Dell > > on server or client BIOS. I do agree this table describes the behavior > > that DCDBAS > driver > > has used since before even UEFI BIOS pretty accurately. > > So, EPS table has been for ages in Dell

Re: [PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-07-02 Thread Andy Shevchenko
On Mon, Jul 2, 2018 at 5:07 PM, wrote: >> >> OK, now the most important question, did you investigate "SMM >> >> Communication ACPI Table"? >> >> Can you utilize information in it? >> >> > Dell BIOS does not provide a "SMM Communication ACPI Table", just the EPS. >> > It >> appears >> > that

Re: [PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-07-02 Thread Andy Shevchenko
On Mon, Jul 2, 2018 at 5:07 PM, wrote: >> >> OK, now the most important question, did you investigate "SMM >> >> Communication ACPI Table"? >> >> Can you utilize information in it? >> >> > Dell BIOS does not provide a "SMM Communication ACPI Table", just the EPS. >> > It >> appears >> > that

RE: [PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-07-02 Thread Mario.Limonciello
> -Original Message- > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > Sent: Friday, June 29, 2018 2:30 PM > To: Stuart Hayes > Cc: Darren Hart; Limonciello, Mario; Linux Kernel Mailing List; Platform > Driver > Subject: Re: [PATCH v3] dcdbas: Add suppor

RE: [PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-07-02 Thread Mario.Limonciello
> -Original Message- > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > Sent: Friday, June 29, 2018 2:30 PM > To: Stuart Hayes > Cc: Darren Hart; Limonciello, Mario; Linux Kernel Mailing List; Platform > Driver > Subject: Re: [PATCH v3] dcdbas: Add suppor

Re: [PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-06-29 Thread Andy Shevchenko
On Fri, Jun 29, 2018 at 9:56 PM, Stuart Hayes wrote: > On 06/27/2018 06:52 PM, Andy Shevchenko wrote: >> On Fri, Jun 15, 2018 at 1:31 AM, Stuart Hayes >> wrote: >>> On 6/14/2018 12:25 PM, Andy Shevchenko wrote: On Thu, Jun 14, 2018 at 5:22 PM, Stuart Hayes wrote: > On 6/13/2018

Re: [PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-06-29 Thread Andy Shevchenko
On Fri, Jun 29, 2018 at 9:56 PM, Stuart Hayes wrote: > On 06/27/2018 06:52 PM, Andy Shevchenko wrote: >> On Fri, Jun 15, 2018 at 1:31 AM, Stuart Hayes >> wrote: >>> On 6/14/2018 12:25 PM, Andy Shevchenko wrote: On Thu, Jun 14, 2018 at 5:22 PM, Stuart Hayes wrote: > On 6/13/2018

Re: [PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-06-29 Thread Stuart Hayes
On 06/27/2018 06:52 PM, Andy Shevchenko wrote: > On Fri, Jun 15, 2018 at 1:31 AM, Stuart Hayes > wrote: >> On 6/14/2018 12:25 PM, Andy Shevchenko wrote: >>> On Thu, Jun 14, 2018 at 5:22 PM, Stuart Hayes >>> wrote: On 6/13/2018 3:54 AM, Andy Shevchenko wrote: >>> >> +

Re: [PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-06-29 Thread Stuart Hayes
On 06/27/2018 06:52 PM, Andy Shevchenko wrote: > On Fri, Jun 15, 2018 at 1:31 AM, Stuart Hayes > wrote: >> On 6/14/2018 12:25 PM, Andy Shevchenko wrote: >>> On Thu, Jun 14, 2018 at 5:22 PM, Stuart Hayes >>> wrote: On 6/13/2018 3:54 AM, Andy Shevchenko wrote: >>> >> +

Re: [PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-06-27 Thread Andy Shevchenko
On Fri, Jun 15, 2018 at 1:31 AM, Stuart Hayes wrote: > On 6/14/2018 12:25 PM, Andy Shevchenko wrote: >> On Thu, Jun 14, 2018 at 5:22 PM, Stuart Hayes >> wrote: >>> On 6/13/2018 3:54 AM, Andy Shevchenko wrote: >> > +* Provide physical address of command buffer field within

Re: [PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-06-27 Thread Andy Shevchenko
On Fri, Jun 15, 2018 at 1:31 AM, Stuart Hayes wrote: > On 6/14/2018 12:25 PM, Andy Shevchenko wrote: >> On Thu, Jun 14, 2018 at 5:22 PM, Stuart Hayes >> wrote: >>> On 6/13/2018 3:54 AM, Andy Shevchenko wrote: >> > +* Provide physical address of command buffer field within

Re: [PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-06-14 Thread Stuart Hayes
On 6/14/2018 12:25 PM, Andy Shevchenko wrote: > On Thu, Jun 14, 2018 at 5:22 PM, Stuart Hayes > wrote: >> On 6/13/2018 3:54 AM, Andy Shevchenko wrote: > +* Provide physical address of command buffer field within +* the struct smi_cmd... can't use

Re: [PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-06-14 Thread Stuart Hayes
On 6/14/2018 12:25 PM, Andy Shevchenko wrote: > On Thu, Jun 14, 2018 at 5:22 PM, Stuart Hayes > wrote: >> On 6/13/2018 3:54 AM, Andy Shevchenko wrote: > +* Provide physical address of command buffer field within +* the struct smi_cmd... can't use

Re: [PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-06-14 Thread Andy Shevchenko
On Thu, Jun 14, 2018 at 5:22 PM, Stuart Hayes wrote: > On 6/13/2018 3:54 AM, Andy Shevchenko wrote: >>> +* Provide physical address of command buffer field within >>> +* the struct smi_cmd... can't use virt_to_phys on smi_cmd >>> +* because address

Re: [PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-06-14 Thread Andy Shevchenko
On Thu, Jun 14, 2018 at 5:22 PM, Stuart Hayes wrote: > On 6/13/2018 3:54 AM, Andy Shevchenko wrote: >>> +* Provide physical address of command buffer field within >>> +* the struct smi_cmd... can't use virt_to_phys on smi_cmd >>> +* because address

Re: [PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-06-14 Thread Stuart Hayes
On 6/13/2018 3:54 AM, Andy Shevchenko wrote: >> + /* Calling Interface SMI > > I suppose the style of the comments like > /* > * Calling ... > ... Yes... goof on my part. Thanks. >> +* >> +* Provide physical address of command buffer field

Re: [PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-06-14 Thread Stuart Hayes
On 6/13/2018 3:54 AM, Andy Shevchenko wrote: >> + /* Calling Interface SMI > > I suppose the style of the comments like > /* > * Calling ... > ... Yes... goof on my part. Thanks. >> +* >> +* Provide physical address of command buffer field

Re: [PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-06-13 Thread Andy Shevchenko
On Wed, Jun 13, 2018 at 4:24 AM, Stuart Hayes wrote: > > If the WSMT ACPI table is present and indicates that a fixed communication > buffer should be used, use the firmware-specified buffer instead of > allocating a buffer in memory for communications between the dcdbas driver > and firmare.

Re: [PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-06-13 Thread Andy Shevchenko
On Wed, Jun 13, 2018 at 4:24 AM, Stuart Hayes wrote: > > If the WSMT ACPI table is present and indicates that a fixed communication > buffer should be used, use the firmware-specified buffer instead of > allocating a buffer in memory for communications between the dcdbas driver > and firmare.

[PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-06-12 Thread Stuart Hayes
If the WSMT ACPI table is present and indicates that a fixed communication buffer should be used, use the firmware-specified buffer instead of allocating a buffer in memory for communications between the dcdbas driver and firmare. Signed-off-by: Stuart Hayes --- v2 Bumped driver version to

[PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-06-12 Thread Stuart Hayes
If the WSMT ACPI table is present and indicates that a fixed communication buffer should be used, use the firmware-specified buffer instead of allocating a buffer in memory for communications between the dcdbas driver and firmare. Signed-off-by: Stuart Hayes --- v2 Bumped driver version to