Re: [PATCH v3] dmaengine: rcar-dmac: use TCRB instead of TCR for residue

2017-11-08 Thread Vinod Koul
On Wed, Nov 08, 2017 at 06:33:33AM +, Kuninori Morimoto wrote: > > Hi Vinod > > > > > > This is now commit 847449f23dcbff68 ("dmaengine: rcar-dmac: use TCRB > > > > > instead of TCR for residue") in slave-dma/next, and breaks serial > > > > > console > > > > > input on koelsch (shmobile_defc

Re: [PATCH v3] dmaengine: rcar-dmac: use TCRB instead of TCR for residue

2017-11-07 Thread Kuninori Morimoto
Hi Vinod > > > > This is now commit 847449f23dcbff68 ("dmaengine: rcar-dmac: use TCRB > > > > instead of TCR for residue") in slave-dma/next, and breaks serial > > > > console > > > > input on koelsch (shmobile_defconfig) and salvator-x > > > > (renesas_defconfig). > > > > Reverting that commit

Re: [PATCH v3] dmaengine: rcar-dmac: use TCRB instead of TCR for residue

2017-11-07 Thread Vinod Koul
On Tue, Oct 31, 2017 at 05:11:13PM +0530, Vinod Koul wrote: > On Tue, Oct 31, 2017 at 11:46:36AM +0100, Geert Uytterhoeven wrote: > > > > > > This is now commit 847449f23dcbff68 ("dmaengine: rcar-dmac: use TCRB > > > instead of TCR for residue") in slave-dma/next, and breaks serial console > > > in

Re: [PATCH v3] dmaengine: rcar-dmac: use TCRB instead of TCR for residue

2017-11-06 Thread Geert Uytterhoeven
Hi Morimoto-san, On Mon, Nov 6, 2017 at 2:24 AM, Kuninori Morimoto wrote: >> Large serial console input (copy and pasting long lines) works, as that uses >> DMA. Small serial console input (typing) doesn't work. >> >> Apparently for the serial port, TCR contains the value we need (< 0x20), >> whi

Re: [PATCH v3] dmaengine: rcar-dmac: use TCRB instead of TCR for residue

2017-11-05 Thread Kuninori Morimoto
Hi Geert > Large serial console input (copy and pasting long lines) works, as that uses > DMA. Small serial console input (typing) doesn't work. > > Apparently for the serial port, TCR contains the value we need (< 0x20), > while TCRB always contains 0x20. > Perhaps the code should use the minimu

Re: [PATCH v3] dmaengine: rcar-dmac: use TCRB instead of TCR for residue

2017-10-31 Thread Kuninori Morimoto
Hi Geert, Vinod Geert, thank you for your report, Vinod, thank you for your quick help. > > > This is now commit 847449f23dcbff68 ("dmaengine: rcar-dmac: use TCRB > > > instead of TCR for residue") in slave-dma/next, and breaks serial console > > > input on koelsch (shmobile_defconfig) and salva

Re: [PATCH v3] dmaengine: rcar-dmac: use TCRB instead of TCR for residue

2017-10-31 Thread Vinod Koul
On Tue, Oct 31, 2017 at 11:46:36AM +0100, Geert Uytterhoeven wrote: > CC linux-renesas-soc > > On Tue, Oct 31, 2017 at 11:45 AM, Geert Uytterhoeven > wrote: > > Hi Vinod, Morimoto-san, Yokoyama-san, > > > > On Fri, Oct 20, 2017 at 8:15 AM, Vinod Koul wrote: > >> On Thu, Oct 19, 2017 at 01:15:13A

Re: [PATCH v3] dmaengine: rcar-dmac: use TCRB instead of TCR for residue

2017-10-31 Thread Geert Uytterhoeven
CC linux-renesas-soc On Tue, Oct 31, 2017 at 11:45 AM, Geert Uytterhoeven wrote: > Hi Vinod, Morimoto-san, Yokoyama-san, > > On Fri, Oct 20, 2017 at 8:15 AM, Vinod Koul wrote: >> On Thu, Oct 19, 2017 at 01:15:13AM +, Kuninori Morimoto wrote: >>> From: Hiroyuki Yokoyama >>> >>> SYS/RT/Audio

Re: [PATCH v3] dmaengine: rcar-dmac: use TCRB instead of TCR for residue

2017-10-31 Thread Geert Uytterhoeven
Hi Vinod, Morimoto-san, Yokoyama-san, On Fri, Oct 20, 2017 at 8:15 AM, Vinod Koul wrote: > On Thu, Oct 19, 2017 at 01:15:13AM +, Kuninori Morimoto wrote: >> From: Hiroyuki Yokoyama >> >> SYS/RT/Audio DMAC includes independent data buffers for reading >> and writing. Therefore, the read trans

Re: [PATCH v3] dmaengine: rcar-dmac: use TCRB instead of TCR for residue

2017-10-19 Thread Vinod Koul
On Thu, Oct 19, 2017 at 01:15:13AM +, Kuninori Morimoto wrote: > From: Hiroyuki Yokoyama > > SYS/RT/Audio DMAC includes independent data buffers for reading > and writing. Therefore, the read transfer counter and write transfer > counter have different values. > TCR indicates read counter, an

Re: [PATCH v3] dmaengine: rcar-dmac: use TCRB instead of TCR for residue

2017-10-19 Thread Laurent Pinchart
Hi Morimoto-san, Thank you for the patch. On Thursday, 19 October 2017 04:15:13 EEST Kuninori Morimoto wrote: > From: Hiroyuki Yokoyama > > SYS/RT/Audio DMAC includes independent data buffers for reading > and writing. Therefore, the read transfer counter and write transfer > counter have diffe

Re: [PATCH v3] dmaengine: rcar-dmac: use TCRB instead of TCR for residue

2017-10-19 Thread Geert Uytterhoeven
On Thu, Oct 19, 2017 at 3:15 AM, Kuninori Morimoto wrote: > From: Hiroyuki Yokoyama > > SYS/RT/Audio DMAC includes independent data buffers for reading > and writing. Therefore, the read transfer counter and write transfer > counter have different values. > TCR indicates read counter, and TCRB in

[PATCH v3] dmaengine: rcar-dmac: use TCRB instead of TCR for residue

2017-10-18 Thread Kuninori Morimoto
From: Hiroyuki Yokoyama SYS/RT/Audio DMAC includes independent data buffers for reading and writing. Therefore, the read transfer counter and write transfer counter have different values. TCR indicates read counter, and TCRB indicates write counter. The relationship is like below. TCR