Re: [PATCH v3] drm/gma500: fix double freeing

2016-04-07 Thread Patrik Jakobsson
On Thu, Apr 7, 2016 at 5:52 PM, Sudip Mukherjee wrote: > On Wednesday 09 December 2015 05:50 PM, Patrik Jakobsson wrote: >> >> On Wed, Dec 9, 2015 at 12:53 PM, Sudip Mukherjee >> wrote: >>> >>> On Thu, Oct 08, 2015 at 06:17:48PM +0530, Sudip Mukherjee wrote: We are allocating backing us

Re: [PATCH v3] drm/gma500: fix double freeing

2016-04-07 Thread Sudip Mukherjee
On Wednesday 09 December 2015 05:50 PM, Patrik Jakobsson wrote: On Wed, Dec 9, 2015 at 12:53 PM, Sudip Mukherjee wrote: On Thu, Oct 08, 2015 at 06:17:48PM +0530, Sudip Mukherjee wrote: We are allocating backing using psbfb_alloc() and so backing->stolen is always true. So we were freeing backi

Re: [PATCH v3] drm/gma500: fix double freeing

2015-12-09 Thread Patrik Jakobsson
On Wed, Dec 9, 2015 at 12:53 PM, Sudip Mukherjee wrote: > On Thu, Oct 08, 2015 at 06:17:48PM +0530, Sudip Mukherjee wrote: >> We are allocating backing using psbfb_alloc() and so >> backing->stolen is always true. So we were freeing backing two times. >> Moreover if we follow the execution path th

Re: [PATCH v3] drm/gma500: fix double freeing

2015-12-09 Thread Sudip Mukherjee
On Thu, Oct 08, 2015 at 06:17:48PM +0530, Sudip Mukherjee wrote: > We are allocating backing using psbfb_alloc() and so > backing->stolen is always true. So we were freeing backing two times. > Moreover if we follow the execution path then we should be freeing > backing after we have released the h

[PATCH v3] drm/gma500: fix double freeing

2015-10-08 Thread Sudip Mukherjee
We are allocating backing using psbfb_alloc() and so backing->stolen is always true. So we were freeing backing two times. Moreover if we follow the execution path then we should be freeing backing after we have released the helper. So remove the one which frees backing before the helper is release