Re: [PATCH v3] ext4: missing !bh check in ext4_xattr_inode_write()

2018-11-09 Thread Theodore Y. Ts'o
On Fri, Nov 09, 2018 at 08:49:48AM +0300, Vasily Averin wrote: > According to Ted Ts'o ext4_getblk() called in ext4_xattr_inode_write() > should not return bh = NULL > > The only time that bh could be NULL, then, would be in the case of > something really going wrong; a programming error elsewhere

[PATCH v3] ext4: missing !bh check in ext4_xattr_inode_write()

2018-11-08 Thread Vasily Averin
According to Ted Ts'o ext4_getblk() called in ext4_xattr_inode_write() should not return bh = NULL The only time that bh could be NULL, then, would be in the case of something really going wrong; a programming error elsewhere (perhaps a wild pointer dereference) or I/O error causing on-disk file s