Re: [PATCH v3] f2fs: add cur_reserved_blocks to support soft block reservation

2017-10-25 Thread Yunlong Song
Agree On 2017/10/26 11:26, Chao Yu wrote: On 2017/10/26 11:07, Yunlong Song wrote: Yes, I agree with the soft semantic you introduce, it is too slow to increase cur_reserved_blocks only in dec_valid_block(,node)_count, e.g. if users want to set cur_reserved_blocks to 10G. Yup, Then how about

Re: [PATCH v3] f2fs: add cur_reserved_blocks to support soft block reservation

2017-10-25 Thread Chao Yu
On 2017/10/26 11:07, Yunlong Song wrote: > Yes, I agree with the soft semantic you introduce, it is too slow to > increase cur_reserved_blocks only in > dec_valid_block(,node)_count, e.g. if users want to set > cur_reserved_blocks to 10G. Yup, > > Then how about fix the initialization of cur_r

Re: [PATCH v3] f2fs: add cur_reserved_blocks to support soft block reservation

2017-10-25 Thread Yunlong Song
Yes, I agree with the soft semantic you introduce, it is too slow to increase cur_reserved_blocks only in dec_valid_block(,node)_count, e.g. if users want to set cur_reserved_blocks to 10G. Then how about fix the initialization of cur_reserved_blocks in fs/f2fs/super.c as following: sbi->curr

Re: [PATCH v3] f2fs: add cur_reserved_blocks to support soft block reservation

2017-10-25 Thread Chao Yu
On 2017/10/25 22:06, Yunlong Song wrote: > Hi, Chao, >     Please see my comments below. > > On 2017/10/25 20:26, Chao Yu wrote: >> On 2017/10/25 18:02, Yunlong Song wrote: >>> ping... >> I've replied in this thread, check your email list please, or you can check >> the >> comments in below link:

Re: [PATCH v3] f2fs: add cur_reserved_blocks to support soft block reservation

2017-10-25 Thread Yunlong Song
Hi, Chao, Please see my comments below. On 2017/10/25 20:26, Chao Yu wrote: On 2017/10/25 18:02, Yunlong Song wrote: ping... I've replied in this thread, check your email list please, or you can check the comments in below link: https://patchwork.kernel.org/patch/9909407/ Anyway, see com

Re: [PATCH v3] f2fs: add cur_reserved_blocks to support soft block reservation

2017-10-25 Thread Chao Yu
On 2017/10/25 18:02, Yunlong Song wrote: > ping... I've replied in this thread, check your email list please, or you can check the comments in below link: https://patchwork.kernel.org/patch/9909407/ Anyway, see comments below. > > On 2017/8/18 23:09, Yunlong Song wrote: >> This patch adds cur_

Re: [PATCH v3] f2fs: add cur_reserved_blocks to support soft block reservation

2017-10-25 Thread Yunlong Song
ping... On 2017/8/18 23:09, Yunlong Song wrote: This patch adds cur_reserved_blocks to extend reserved_blocks sysfs interface to be soft threshold, which allows user configure it exceeding current available user space. To ensure there is enough space for supporting system's activation, this patc

Re: [f2fs-dev] [PATCH v3] f2fs: add cur_reserved_blocks to support soft block reservation

2017-08-18 Thread Chao Yu
On 2017/8/18 23:09, Yunlong Song wrote: > This patch adds cur_reserved_blocks to extend reserved_blocks sysfs > interface to be soft threshold, which allows user configure it exceeding > current available user space. To ensure there is enough space for > supporting system's activation, this patch d

[PATCH v3] f2fs: add cur_reserved_blocks to support soft block reservation

2017-08-18 Thread Yunlong Song
This patch adds cur_reserved_blocks to extend reserved_blocks sysfs interface to be soft threshold, which allows user configure it exceeding current available user space. To ensure there is enough space for supporting system's activation, this patch does not set the reserved space to the configured