Re: [PATCH v3] firmware_loader: fix use-after-free in firmware_fallback_sysfs

2021-04-15 Thread Shuah Khan
On 4/14/21 9:26 AM, Shuah Khan wrote: On 4/14/21 6:55 AM, Luis Chamberlain wrote: Shuah, a question for you toward the end here. On Wed, Apr 14, 2021 at 02:24:05PM +0530, Anirudh Rayabharam wrote: This use-after-free happens when a fw_priv object has been freed but hasn't been removed from the

Re: [PATCH v3] firmware_loader: fix use-after-free in firmware_fallback_sysfs

2021-04-14 Thread Anirudh Rayabharam
On Wed, Apr 14, 2021 at 12:55:40PM +, Luis Chamberlain wrote: > Shuah, a question for you toward the end here. > > On Wed, Apr 14, 2021 at 02:24:05PM +0530, Anirudh Rayabharam wrote: > > This use-after-free happens when a fw_priv object has been freed but > > hasn't been removed from the pendi

Re: [PATCH v3] firmware_loader: fix use-after-free in firmware_fallback_sysfs

2021-04-14 Thread Shuah Khan
On 4/14/21 6:55 AM, Luis Chamberlain wrote: Shuah, a question for you toward the end here. On Wed, Apr 14, 2021 at 02:24:05PM +0530, Anirudh Rayabharam wrote: This use-after-free happens when a fw_priv object has been freed but hasn't been removed from the pending list (pending_fw_head). The ne

Re: [PATCH v3] firmware_loader: fix use-after-free in firmware_fallback_sysfs

2021-04-14 Thread Luis Chamberlain
Shuah, a question for you toward the end here. On Wed, Apr 14, 2021 at 02:24:05PM +0530, Anirudh Rayabharam wrote: > This use-after-free happens when a fw_priv object has been freed but > hasn't been removed from the pending list (pending_fw_head). The next > time fw_load_sysfs_fallback tries to i

[PATCH v3] firmware_loader: fix use-after-free in firmware_fallback_sysfs

2021-04-14 Thread Anirudh Rayabharam
This use-after-free happens when a fw_priv object has been freed but hasn't been removed from the pending list (pending_fw_head). The next time fw_load_sysfs_fallback tries to insert into the list, it ends up accessing the pending_list member of the previoiusly freed fw_priv. The root cause here i