Re: [PATCH v3] gpio: Add device driver for GRGPIO cores and support custom accessors with gpio-generic

2013-03-08 Thread Andreas Larsson
On Thu, 2013-03-07 at 04:44 +0100, Linus Walleij wrote: > On Mon, Mar 4, 2013 at 10:46 AM, Andreas Larsson wrote: > > [Me] > >>> +struct grgpio_priv { > >>> + struct bgpio_chip bgc; > >>> + struct grgpio_regs __iomem *regs; > >>> + > >>> + u32 imask; /* irq mask shadow regis

Re: [PATCH v3] gpio: Add device driver for GRGPIO cores and support custom accessors with gpio-generic

2013-03-06 Thread Linus Walleij
On Mon, Mar 4, 2013 at 10:46 AM, Andreas Larsson wrote: > [Me] >>> +struct grgpio_priv { >>> + struct bgpio_chip bgc; >>> + struct grgpio_regs __iomem *regs; >>> + >>> + u32 imask; /* irq mask shadow register */ >>> + s32 *irqmap;/* maps offset to irq or -1 if no i

Re: [PATCH v3] gpio: Add device driver for GRGPIO cores and support custom accessors with gpio-generic

2013-03-04 Thread Andreas Larsson
On 2013-03-01 01:24, Linus Walleij wrote: On Tue, Feb 12, 2013 at 8:24 AM, Andreas Larsson wrote: This driver supports GRGPIO gpio cores available in the GRLIB VHDL IP core library from Aeroflex Gaisler. This also adds support to gpio-generic for using custom accessor functions. The grgpio dr

Re: [PATCH v3] gpio: Add device driver for GRGPIO cores and support custom accessors with gpio-generic

2013-03-03 Thread Grant Likely
On Fri, 1 Mar 2013 01:24:01 +0100, Linus Walleij wrote: > On Tue, Feb 12, 2013 at 8:24 AM, Andreas Larsson wrote: > > > This driver supports GRGPIO gpio cores available in the GRLIB VHDL IP > > core library from Aeroflex Gaisler. > > > > This also adds support to gpio-generic for using custom a

Re: [PATCH v3] gpio: Add device driver for GRGPIO cores and support custom accessors with gpio-generic

2013-02-28 Thread Linus Walleij
On Tue, Feb 12, 2013 at 8:24 AM, Andreas Larsson wrote: > This driver supports GRGPIO gpio cores available in the GRLIB VHDL IP > core library from Aeroflex Gaisler. > > This also adds support to gpio-generic for using custom accessor > functions. The grgpio driver uses this to use ioread32be and

Re: [PATCH v3] gpio: Add device driver for GRGPIO cores and support custom accessors with gpio-generic

2013-02-13 Thread Andreas Larsson
On 2013-02-13 08:05, Anton Vorontsov wrote: On Tue, Feb 12, 2013 at 08:24:33AM +0100, Andreas Larsson wrote: + res = platform_get_resource(ofdev, IORESOURCE_MEM, 0); + regs = devm_request_and_ioremap(&ofdev->dev, res); Just wonder, is it safe to pass null res to devm_request_and_io

Re: [PATCH v3] gpio: Add device driver for GRGPIO cores and support custom accessors with gpio-generic

2013-02-12 Thread Anton Vorontsov
On Tue, Feb 12, 2013 at 08:24:33AM +0100, Andreas Larsson wrote: > This driver supports GRGPIO gpio cores available in the GRLIB VHDL IP > core library from Aeroflex Gaisler. > > This also adds support to gpio-generic for using custom accessor > functions. The grgpio driver uses this to use ioread

[PATCH v3] gpio: Add device driver for GRGPIO cores and support custom accessors with gpio-generic

2013-02-11 Thread Andreas Larsson
This driver supports GRGPIO gpio cores available in the GRLIB VHDL IP core library from Aeroflex Gaisler. This also adds support to gpio-generic for using custom accessor functions. The grgpio driver uses this to use ioread32be and iowrite32be for big endian register accesses. Signed-off-by: Andr