Re: [PATCH v3] gpio: pl061: Fix the issue failed to register the ACPI interrtupion

2019-08-20 Thread Linus Walleij
On Tue, Aug 20, 2019 at 10:51 AM Andy Shevchenko wrote: > On Tue, Aug 20, 2019 at 10:12 AM Linus Walleij > wrote: > > On Mon, Aug 19, 2019 at 5:07 PM Andy Shevchenko > > wrote: > > Exactly what do you refer to when you want me to > > "re-do the approach for IRQ handling"? Do you mean > > this

Re: [PATCH v3] gpio: pl061: Fix the issue failed to register the ACPI interrtupion

2019-08-20 Thread Wei Xu
Hi Linus, On 2019/8/20 16:01, Linus Walleij wrote: On Mon, Aug 19, 2019 at 3:29 PM Wei Xu wrote: Invoke acpi_gpiochip_request_interrupts after the acpi data has been attached to the pl061 acpi node to register interruption. Otherwise it will be failed to register interruption for the ACPI

Re: [PATCH v3] gpio: pl061: Fix the issue failed to register the ACPI interrtupion

2019-08-20 Thread Andy Shevchenko
On Tue, Aug 20, 2019 at 10:12 AM Linus Walleij wrote: > On Mon, Aug 19, 2019 at 5:07 PM Andy Shevchenko > wrote: > > > The proper fix is to revert the culprit since we call > > acpi_gpiochip_request_interrupts() for all controllers. > > Linus, please re-do the approach with IRQ handling, > >

Re: [PATCH v3] gpio: pl061: Fix the issue failed to register the ACPI interrtupion

2019-08-20 Thread Andy Shevchenko
On Tue, Aug 20, 2019 at 10:12 AM Linus Walleij wrote: > > On Mon, Aug 19, 2019 at 5:07 PM Andy Shevchenko > wrote: > > > The proper fix is to revert the culprit since we call > > acpi_gpiochip_request_interrupts() for all controllers. > > Linus, please re-do the approach with IRQ handling, > >

Re: [PATCH v3] gpio: pl061: Fix the issue failed to register the ACPI interrtupion

2019-08-20 Thread Linus Walleij
On Mon, Aug 19, 2019 at 3:29 PM Wei Xu wrote: > Invoke acpi_gpiochip_request_interrupts after the acpi data has been > attached to the pl061 acpi node to register interruption. > > Otherwise it will be failed to register interruption for the ACPI case. > Because in the

Re: [PATCH v3] gpio: pl061: Fix the issue failed to register the ACPI interrtupion

2019-08-20 Thread Linus Walleij
On Mon, Aug 19, 2019 at 5:07 PM Andy Shevchenko wrote: > The proper fix is to revert the culprit since we call > acpi_gpiochip_request_interrupts() for all controllers. > Linus, please re-do the approach with IRQ handling, Exactly what do you refer to when you want me to "re-do the approach for

Re: [PATCH v3] gpio: pl061: Fix the issue failed to register the ACPI interrtupion

2019-08-19 Thread Andy Shevchenko
On Mon, Aug 19, 2019 at 4:29 PM Wei Xu wrote: > > Invoke acpi_gpiochip_request_interrupts after the acpi data has been > attached to the pl061 acpi node to register interruption. > > Otherwise it will be failed to register interruption for the ACPI case. > Because in the

[PATCH v3] gpio: pl061: Fix the issue failed to register the ACPI interrtupion

2019-08-19 Thread Wei Xu
Invoke acpi_gpiochip_request_interrupts after the acpi data has been attached to the pl061 acpi node to register interruption. Otherwise it will be failed to register interruption for the ACPI case. Because in the gpiochip_add_data_with_key, acpi_gpiochip_add is invoked after gpiochip_add_irqchip