Re: [PATCH v3] gpio: twl4030: Cache the direction and output states in private data

2013-02-09 Thread Grant Likely
On Thu, 10 Jan 2013 14:09:35 +0100, Peter Ujfalusi wrote: > Hi Linus, > > On 01/10/2013 11:41 AM, Linus Walleij wrote: > > On Thu, Dec 20, 2012 at 10:44 AM, Peter Ujfalusi > > wrote: > > > >> Use more coherent locking in the driver. Use bitfield to store the GPIO > >> direction and if the pin

Re: [PATCH v3] gpio: twl4030: Cache the direction and output states in private data

2013-01-17 Thread Peter Ujfalusi
Hi Linus, On 01/17/2013 11:43 AM, Linus Walleij wrote: > On Thu, Jan 10, 2013 at 2:09 PM, Peter Ujfalusi wrote: >> On 01/10/2013 11:41 AM, Linus Walleij wrote: > >>> Sorry Peter this must have been missed somehow. >>> >>> This does not apply to the current v3.8-rc3, could you respin >>> this on

Re: [PATCH v3] gpio: twl4030: Cache the direction and output states in private data

2013-01-17 Thread Linus Walleij
On Thu, Jan 10, 2013 at 2:09 PM, Peter Ujfalusi wrote: > On 01/10/2013 11:41 AM, Linus Walleij wrote: >> Sorry Peter this must have been missed somehow. >> >> This does not apply to the current v3.8-rc3, could you respin >> this on top of Torvalds' tree? > > Grant applied the patch which this one

Re: [PATCH v3] gpio: twl4030: Cache the direction and output states in private data

2013-01-10 Thread Peter Ujfalusi
Hi Linus, On 01/10/2013 11:41 AM, Linus Walleij wrote: > On Thu, Dec 20, 2012 at 10:44 AM, Peter Ujfalusi > wrote: > >> Use more coherent locking in the driver. Use bitfield to store the GPIO >> direction and if the pin is configured as output store the status also in a >> bitfiled. >> In this

Re: [PATCH v3] gpio: twl4030: Cache the direction and output states in private data

2013-01-10 Thread Linus Walleij
On Thu, Dec 20, 2012 at 10:44 AM, Peter Ujfalusi wrote: > Use more coherent locking in the driver. Use bitfield to store the GPIO > direction and if the pin is configured as output store the status also in a > bitfiled. > In this way we can just look at these bitfields when we need information >

[PATCH v3] gpio: twl4030: Cache the direction and output states in private data

2012-12-20 Thread Peter Ujfalusi
Use more coherent locking in the driver. Use bitfield to store the GPIO direction and if the pin is configured as output store the status also in a bitfiled. In this way we can just look at these bitfields when we need information about the pin status and only reach out to the chip when it is neede