Re: [PATCH v3] gpio: vt8500: memory cleanup missing

2013-02-09 Thread Grant Likely
On Fri, 18 Jan 2013 17:58:22 +1300, Tony Prisk wrote: > This driver is missing a .remove callback, and the fail path on > probe is incomplete. > > If an error occurs in vt8500_add_chips, gpio_base is not unmapped. > The driver is also ignoring the return value from this function so > if a chip

Re: [PATCH v3] gpio: vt8500: memory cleanup missing

2013-02-09 Thread Grant Likely
On Fri, 18 Jan 2013 17:58:22 +1300, Tony Prisk li...@prisktech.co.nz wrote: This driver is missing a .remove callback, and the fail path on probe is incomplete. If an error occurs in vt8500_add_chips, gpio_base is not unmapped. The driver is also ignoring the return value from this function

[PATCH v3] gpio: vt8500: memory cleanup missing

2013-01-17 Thread Tony Prisk
This driver is missing a .remove callback, and the fail path on probe is incomplete. If an error occurs in vt8500_add_chips, gpio_base is not unmapped. The driver is also ignoring the return value from this function so if a chip fails to register it completes as successful. Replaced pr_err with

[PATCH v3] gpio: vt8500: memory cleanup missing

2013-01-17 Thread Tony Prisk
This driver is missing a .remove callback, and the fail path on probe is incomplete. If an error occurs in vt8500_add_chips, gpio_base is not unmapped. The driver is also ignoring the return value from this function so if a chip fails to register it completes as successful. Replaced pr_err with