Re: [PATCH v3] i2c: aspeed: fix invalid clock parameters for very large divisors

2018-09-22 Thread kbuild test robot
Hi Brendan, I love your patch! Yet something to improve: [auto build test ERROR on wsa/i2c/for-next] [also build test ERROR on v4.19-rc4 next-20180921] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/co

Re: [PATCH v3] i2c: aspeed: fix invalid clock parameters for very large divisors

2018-09-21 Thread Jae Hyun Yoo
On 9/21/2018 3:34 PM, Brendan Higgins wrote: @@ -142,7 +142,8 @@ struct aspeed_i2c_bus { /* Synchronizes I/O mem access to base. */ spinlock_t lock; struct completion cmd_complete; - u32 (*get_clk_reg_val

[PATCH v3] i2c: aspeed: fix invalid clock parameters for very large divisors

2018-09-21 Thread Brendan Higgins
The function that computes clock parameters from divisors did not respect the maximum size of the bitfields that the parameters were written to. This fixes the bug. This bug can be reproduced with (and this fix verified with) the test at: https://kunit-review.googlesource.com/c/linux/+/1035/ Disc