Re: [PATCH v3] iio: light: Add support for ROHM RPR0521 sensor

2015-06-14 Thread Jonathan Cameron
On 14/06/15 12:28, Daniel Baluta wrote: > On Sun, Jun 14, 2015 at 1:51 PM, Jonathan Cameron wrote: >> On 10/06/15 15:21, Daniel Baluta wrote: >>> This patch adds support for ROHM RPR0521 ambient light and proximity >>> sensor. It offers raw readings for intensity and proximity. >>> >>> Signed-off-

Re: [PATCH v3] iio: light: Add support for ROHM RPR0521 sensor

2015-06-14 Thread Daniel Baluta
On Sun, Jun 14, 2015 at 1:51 PM, Jonathan Cameron wrote: > On 10/06/15 15:21, Daniel Baluta wrote: >> This patch adds support for ROHM RPR0521 ambient light and proximity >> sensor. It offers raw readings for intensity and proximity. >> >> Signed-off-by: Daniel Baluta > Looks good to me. A few c

Re: [PATCH v3] iio: light: Add support for ROHM RPR0521 sensor

2015-06-14 Thread Jonathan Cameron
On 10/06/15 15:21, Daniel Baluta wrote: > This patch adds support for ROHM RPR0521 ambient light and proximity > sensor. It offers raw readings for intensity and proximity. > > Signed-off-by: Daniel Baluta Looks good to me. A few comments inline. Only one I'd really bother making a change for i

[PATCH v3] iio: light: Add support for ROHM RPR0521 sensor

2015-06-10 Thread Daniel Baluta
This patch adds support for ROHM RPR0521 ambient light and proximity sensor. It offers raw readings for intensity and proximity. Signed-off-by: Daniel Baluta --- Changes since v2: (after Peter's review) * replaced calibscale with scale * several style fixes (new lines, spellings,