Re: [PATCH v3] iio: max5487: Add support for Maxim digital potentiometers

2016-05-18 Thread Matt Ranostay
Slight nitpick below. On Tue, May 17, 2016 at 6:11 AM, Cristina Moraru wrote: > Add implementation for Maxim MAX5487, MAX5488, MAX5489 > digital potentiometers. > > Datasheet: > http://datasheets.maximintegrated.com/en/ds/MAX5487-MAX5489.pdf > > Signed-off-by:

Re: [PATCH v3] iio: max5487: Add support for Maxim digital potentiometers

2016-05-18 Thread Matt Ranostay
Slight nitpick below. On Tue, May 17, 2016 at 6:11 AM, Cristina Moraru wrote: > Add implementation for Maxim MAX5487, MAX5488, MAX5489 > digital potentiometers. > > Datasheet: > http://datasheets.maximintegrated.com/en/ds/MAX5487-MAX5489.pdf > > Signed-off-by: Cristina Moraru > CC: Daniel

Re: [PATCH v3] iio: max5487: Add support for Maxim digital potentiometers

2016-05-17 Thread Peter Meerwald-Stadler
> Add implementation for Maxim MAX5487, MAX5488, MAX5489 > digital potentiometers. comments below > Datasheet: > http://datasheets.maximintegrated.com/en/ds/MAX5487-MAX5489.pdf > > Signed-off-by: Cristina Moraru > CC: Daniel Baluta > ---

Re: [PATCH v3] iio: max5487: Add support for Maxim digital potentiometers

2016-05-17 Thread Peter Meerwald-Stadler
> Add implementation for Maxim MAX5487, MAX5488, MAX5489 > digital potentiometers. comments below > Datasheet: > http://datasheets.maximintegrated.com/en/ds/MAX5487-MAX5489.pdf > > Signed-off-by: Cristina Moraru > CC: Daniel Baluta > --- > Changes since v2: > Change switch statement

[PATCH v3] iio: max5487: Add support for Maxim digital potentiometers

2016-05-17 Thread Cristina Moraru
Add implementation for Maxim MAX5487, MAX5488, MAX5489 digital potentiometers. Datasheet: http://datasheets.maximintegrated.com/en/ds/MAX5487-MAX5489.pdf Signed-off-by: Cristina Moraru CC: Daniel Baluta --- Changes since v2: Change

[PATCH v3] iio: max5487: Add support for Maxim digital potentiometers

2016-05-17 Thread Cristina Moraru
Add implementation for Maxim MAX5487, MAX5488, MAX5489 digital potentiometers. Datasheet: http://datasheets.maximintegrated.com/en/ds/MAX5487-MAX5489.pdf Signed-off-by: Cristina Moraru CC: Daniel Baluta --- Changes since v2: Change switch statement in max5487_write_raw to if