Re: [PATCH v3] init: Do not select DEBUG_KERNEL by default

2019-04-11 Thread Josh Triplett
On Thu, Apr 11, 2019 at 10:00:24AM -0700, Kees Cook wrote: > On Wed, Apr 10, 2019 at 10:34 PM Masahiro Yamada > wrote: > > > > On Thu, Apr 11, 2019 at 11:47 AM Kees Cook wrote: > > > > > > On Wed, Apr 10, 2019 at 5:56 PM Sinan Kaya wrote: > > > > > > > > We can't seem to have a kernel with

Re: [PATCH v3] init: Do not select DEBUG_KERNEL by default

2019-04-11 Thread Sinan Kaya
On 4/11/2019 1:48 AM, Masahiro Yamada wrote: I was going by what Kconfig tells me Symbol: KALLSYMS_ALL [=n] Depends on: DEBUG_KERNEL [=n] && KALLSYMS [=y] Lots of features have 'depends on DEBUG_KERNEL'. What is special about KALLSYMS_ALL here? I had to do some learning about

Re: [PATCH v3] init: Do not select DEBUG_KERNEL by default

2019-04-11 Thread Kees Cook
On Wed, Apr 10, 2019 at 10:34 PM Masahiro Yamada wrote: > > On Thu, Apr 11, 2019 at 11:47 AM Kees Cook wrote: > > > > On Wed, Apr 10, 2019 at 5:56 PM Sinan Kaya wrote: > > > > > > We can't seem to have a kernel with CONFIG_EXPERT set but > > > CONFIG_DEBUG_KERNEL unset these days. > > > > > >

Re: [PATCH v3] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Masahiro Yamada
On Thu, Apr 11, 2019 at 2:44 PM Sinan Kaya wrote: > > On 4/11/2019 1:31 AM, Masahiro Yamada wrote: > >> t looks like CONFIG_KALLSYMS_ALL is the only feature that > >> requires CONFIG_DEBUG_KERNEL. > > Which part of KALLSYMS_ALL code requires CONFIG_DEBUG_KERNEL? > > > > I was going by what

Re: [PATCH v3] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Sinan Kaya
On 4/11/2019 1:31 AM, Masahiro Yamada wrote: t looks like CONFIG_KALLSYMS_ALL is the only feature that requires CONFIG_DEBUG_KERNEL. Which part of KALLSYMS_ALL code requires CONFIG_DEBUG_KERNEL? I was going by what Kconfig tells me Symbol: KALLSYMS_ALL [=n] Depends on: DEBUG_KERNEL [=n] &&

Re: [PATCH v3] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Masahiro Yamada
On Thu, Apr 11, 2019 at 11:47 AM Kees Cook wrote: > > On Wed, Apr 10, 2019 at 5:56 PM Sinan Kaya wrote: > > > > We can't seem to have a kernel with CONFIG_EXPERT set but > > CONFIG_DEBUG_KERNEL unset these days. > > > > While some of the features under the CONFIG_EXPERT require > >

Re: [PATCH v3] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Masahiro Yamada
On Thu, Apr 11, 2019 at 9:59 AM Sinan Kaya wrote: > > We can't seem to have a kernel with CONFIG_EXPERT set but > CONFIG_DEBUG_KERNEL unset these days. > > While some of the features under the CONFIG_EXPERT require > CONFIG_DEBUG_KERNEL, it doesn't apply for all features. > > It looks like

Re: [PATCH v3] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Kees Cook
On Wed, Apr 10, 2019 at 5:56 PM Sinan Kaya wrote: > > We can't seem to have a kernel with CONFIG_EXPERT set but > CONFIG_DEBUG_KERNEL unset these days. > > While some of the features under the CONFIG_EXPERT require > CONFIG_DEBUG_KERNEL, it doesn't apply for all features. > > It looks like

[PATCH v3] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Sinan Kaya
We can't seem to have a kernel with CONFIG_EXPERT set but CONFIG_DEBUG_KERNEL unset these days. While some of the features under the CONFIG_EXPERT require CONFIG_DEBUG_KERNEL, it doesn't apply for all features. It looks like CONFIG_KALLSYMS_ALL is the only feature that requires