Re: [PATCH v3] ipc/shm: kill the historical/wrong mm->start_stack check

2014-08-26 Thread Hugh Dickins
On Tue, 26 Aug 2014, Oleg Nesterov wrote: > do_shmat() is the only user of ->start_stack (proc just reports its > value), and this check looks ugly and wrong. > > The reason for this check is not clear at all, and it wrongly assumes > that the stack can only grow down. > > But the main problem i

[PATCH v3] ipc/shm: kill the historical/wrong mm->start_stack check

2014-08-26 Thread Oleg Nesterov
do_shmat() is the only user of ->start_stack (proc just reports its value), and this check looks ugly and wrong. The reason for this check is not clear at all, and it wrongly assumes that the stack can only grow down. But the main problem is that in general mm->start_stack has nothing to do with