Re: [PATCH v3] kdb: remove unnecessary null check of dbg_io_ops

2020-07-10 Thread Daniel Thompson
On Fri, Jul 10, 2020 at 03:15:55PM +0300, Cengiz Can wrote: > Hello Daniel, > > On 2020-07-01 01:32, Doug Anderson wrote: > > > > Reviewed-by: Douglas Anderson > > Tested-by: Douglas Anderson > > Wanted to ask about the status of this proposed patch. > > I have checked your tree in

Re: [PATCH v3] kdb: remove unnecessary null check of dbg_io_ops

2020-07-10 Thread Cengiz Can
Hello Daniel, On 2020-07-01 01:32, Doug Anderson wrote: Reviewed-by: Douglas Anderson Tested-by: Douglas Anderson Wanted to ask about the status of this proposed patch. I have checked your tree in git.kernel.org but you might be collecting them somewhere else perhaps. Thank you for your

Re: [PATCH v3] kdb: remove unnecessary null check of dbg_io_ops

2020-06-30 Thread Doug Anderson
Hi, On Tue, Jun 30, 2020 at 1:30 AM Cengiz Can wrote: > > `kdb_msg_write` operates on a global `struct kgdb_io *` called > `dbg_io_ops`. > > It's initialized in `debug_core.c` and checked throughout the debug > flow. > > There's a null check in `kdb_msg_write` which triggers static analyzers >

Re: [PATCH v3] kdb: remove unnecessary null check of dbg_io_ops

2020-06-30 Thread Andy Shevchenko
On Tue, Jun 30, 2020 at 05:06:31PM +0530, Sumit Garg wrote: > On Tue, 30 Jun 2020 at 14:00, Cengiz Can wrote: > > > > `kdb_msg_write` operates on a global `struct kgdb_io *` called > > `dbg_io_ops`. > > > > It's initialized in `debug_core.c` and checked throughout the debug > > flow. > > > >

Re: [PATCH v3] kdb: remove unnecessary null check of dbg_io_ops

2020-06-30 Thread Sumit Garg
On Tue, 30 Jun 2020 at 14:00, Cengiz Can wrote: > > `kdb_msg_write` operates on a global `struct kgdb_io *` called > `dbg_io_ops`. > > It's initialized in `debug_core.c` and checked throughout the debug > flow. > > There's a null check in `kdb_msg_write` which triggers static analyzers > and

[PATCH v3] kdb: remove unnecessary null check of dbg_io_ops

2020-06-30 Thread Cengiz Can
`kdb_msg_write` operates on a global `struct kgdb_io *` called `dbg_io_ops`. It's initialized in `debug_core.c` and checked throughout the debug flow. There's a null check in `kdb_msg_write` which triggers static analyzers and gives the (almost entirely wrong) impression that it can be null.