Re: [PATCH v3] kernel/module: Fix mem leak in module_add_modinfo_attrs

2019-06-11 Thread Greg KH
On Tue, Jun 11, 2019 at 10:30:56PM +0800, Yuehaibing wrote: > On 2019/6/11 21:33, Jessica Yu wrote: > > +++ YueHaibing [03/06/19 22:45 +0800]: > >> In module_add_modinfo_attrs if sysfs_create_file > >> fails, we forget to free allocated modinfo_attrs > >> and roll back the sysfs files. > >> > >>

Re: [PATCH v3] kernel/module: Fix mem leak in module_add_modinfo_attrs

2019-06-11 Thread Yuehaibing
On 2019/6/11 21:33, Jessica Yu wrote: > +++ YueHaibing [03/06/19 22:45 +0800]: >> In module_add_modinfo_attrs if sysfs_create_file >> fails, we forget to free allocated modinfo_attrs >> and roll back the sysfs files. >> >> Fixes: 03e88ae1b13d ("[PATCH] fix module sysfs files reference counting")

Re: [PATCH v3] kernel/module: Fix mem leak in module_add_modinfo_attrs

2019-06-11 Thread Jessica Yu
+++ YueHaibing [03/06/19 22:45 +0800]: In module_add_modinfo_attrs if sysfs_create_file fails, we forget to free allocated modinfo_attrs and roll back the sysfs files. Fixes: 03e88ae1b13d ("[PATCH] fix module sysfs files reference counting") Signed-off-by: YueHaibing --- v3: reuse

Re: [PATCH v3] kernel/module: Fix mem leak in module_add_modinfo_attrs

2019-06-07 Thread Jessica Yu
+++ Miroslav Benes [04/06/19 12:46 +0200]: On Mon, 3 Jun 2019, YueHaibing wrote: In module_add_modinfo_attrs if sysfs_create_file fails, we forget to free allocated modinfo_attrs and roll back the sysfs files. Fixes: 03e88ae1b13d ("[PATCH] fix module sysfs files reference counting")

Re: [PATCH v3] kernel/module: Fix mem leak in module_add_modinfo_attrs

2019-06-04 Thread Miroslav Benes
> >> -static void module_remove_modinfo_attrs(struct module *mod) > >> +static void module_remove_modinfo_attrs(struct module *mod, int end) > >> { > >>struct module_attribute *attr; > >>int i; > >> > >>for (i = 0; (attr = >modinfo_attrs[i]); i++) { > >> + if (end >= 0 && i

Re: [PATCH v3] kernel/module: Fix mem leak in module_add_modinfo_attrs

2019-06-04 Thread Yuehaibing
On 2019/6/4 18:46, Miroslav Benes wrote: > On Mon, 3 Jun 2019, YueHaibing wrote: > >> In module_add_modinfo_attrs if sysfs_create_file >> fails, we forget to free allocated modinfo_attrs >> and roll back the sysfs files. >> >> Fixes: 03e88ae1b13d ("[PATCH] fix module sysfs files reference

Re: [PATCH v3] kernel/module: Fix mem leak in module_add_modinfo_attrs

2019-06-04 Thread Miroslav Benes
On Mon, 3 Jun 2019, YueHaibing wrote: > In module_add_modinfo_attrs if sysfs_create_file > fails, we forget to free allocated modinfo_attrs > and roll back the sysfs files. > > Fixes: 03e88ae1b13d ("[PATCH] fix module sysfs files reference counting") > Signed-off-by: YueHaibing > --- > v3:

[PATCH v3] kernel/module: Fix mem leak in module_add_modinfo_attrs

2019-06-03 Thread YueHaibing
In module_add_modinfo_attrs if sysfs_create_file fails, we forget to free allocated modinfo_attrs and roll back the sysfs files. Fixes: 03e88ae1b13d ("[PATCH] fix module sysfs files reference counting") Signed-off-by: YueHaibing --- v3: reuse module_remove_modinfo_attrs v2: free from '--i'