Re: [PATCH v3] kexec: Make a pair of map and unmap reserved pages when kdump fails to start

2015-07-10 Thread Michael Holzheu
On Fri, 10 Jul 2015 12:05:27 +0800 Minfei Huang wrote: > On 07/09/15 at 05:54P, Michael Holzheu wrote: > > On Tue, 7 Jul 2015 17:18:40 -0400 > > Vivek Goyal wrote: > > > > > On Thu, Jul 02, 2015 at 09:45:52AM +0800, Minfei Huang wrote: > > > > [snip] > > > > > I am thinking of moving kernel l

Re: [PATCH v3] kexec: Make a pair of map and unmap reserved pages when kdump fails to start

2015-07-09 Thread Minfei Huang
On 07/09/15 at 05:54P, Michael Holzheu wrote: > On Tue, 7 Jul 2015 17:18:40 -0400 > Vivek Goyal wrote: > > > On Thu, Jul 02, 2015 at 09:45:52AM +0800, Minfei Huang wrote: > > [snip] > > > I am thinking of moving kernel loading code in a separate function to > > make things little simpler. Right

Re: [PATCH v3] kexec: Make a pair of map and unmap reserved pages when kdump fails to start

2015-07-09 Thread Minfei Huang
Hi, Michael. Yes, The code is more readable after wrapping the all of function code in a function. Since this is a small issue, I think it is better to use one patch to fix it. I am glad to repost a patch to merge you and Vivek's patches as one patch. Thanks Minfei On 07/09/15 at 05:54P, Michael

Re: [PATCH v3] kexec: Make a pair of map and unmap reserved pages when kdump fails to start

2015-07-09 Thread Michael Holzheu
On Tue, 7 Jul 2015 17:18:40 -0400 Vivek Goyal wrote: > On Thu, Jul 02, 2015 at 09:45:52AM +0800, Minfei Huang wrote: [snip] > I am thinking of moving kernel loading code in a separate function to > make things little simpler. Right now it is confusing. > > Can you please test attached patch. I

Re: [PATCH v3] kexec: Make a pair of map and unmap reserved pages when kdump fails to start

2015-07-08 Thread Minfei Huang
On 07/08/15 at 08:06P, Minfei Huang wrote: > On 07/07/15 at 05:18P, Vivek Goyal wrote: > > On Thu, Jul 02, 2015 at 09:45:52AM +0800, Minfei Huang wrote: > > > For some arch, kexec shall map the reserved pages, then use them, when > > > we try to start the kdump service. > > > > > > Now kexec will

Re: [PATCH v3] kexec: Make a pair of map and unmap reserved pages when kdump fails to start

2015-07-08 Thread Minfei Huang
On 07/07/15 at 05:18P, Vivek Goyal wrote: > On Thu, Jul 02, 2015 at 09:45:52AM +0800, Minfei Huang wrote: > > For some arch, kexec shall map the reserved pages, then use them, when > > we try to start the kdump service. > > > > Now kexec will never unmap the reserved pages, once it fails to contin

Re: [PATCH v3] kexec: Make a pair of map and unmap reserved pages when kdump fails to start

2015-07-07 Thread Vivek Goyal
On Thu, Jul 02, 2015 at 09:45:52AM +0800, Minfei Huang wrote: > For some arch, kexec shall map the reserved pages, then use them, when > we try to start the kdump service. > > Now kexec will never unmap the reserved pages, once it fails to continue > starting the kdump service. > > Make a pair of

[PATCH v3] kexec: Make a pair of map and unmap reserved pages when kdump fails to start

2015-07-01 Thread Minfei Huang
For some arch, kexec shall map the reserved pages, then use them, when we try to start the kdump service. Now kexec will never unmap the reserved pages, once it fails to continue starting the kdump service. Make a pair of reserved pages in kdump starting path, whatever kexec fails or not. Signed