Re: [PATCH v3] media: i2c: tvp514x: add OF support

2013-05-23 Thread Hans Verkuil
On Tue 14 May 2013 13:00:36 Lad Prabhakar wrote: > From: Lad, Prabhakar > > add OF support for the tvp514x driver. Alongside this patch > removes unnecessary header file inclusion and sorts them alphabetically. > > Signed-off-by: Lad, Prabhakar > Cc: Hans Verkuil > Cc: Laurent Pinchart > Cc:

Re: [PATCH v3] media: i2c: tvp514x: add OF support

2013-05-16 Thread Prabhakar Lad
Hi Laurent, On Thu, May 16, 2013 at 6:20 PM, Laurent Pinchart wrote: > Hi Prabhakar, > > On Thursday 16 May 2013 18:13:38 Prabhakar Lad wrote: >> On Thu, May 16, 2013 at 5:40 PM, Laurent Pinchart wrote: >> > Hi Prabhakar, >> >> [Snip] >> >> >> + >> >> + pdata = devm_kzalloc(&client->dev, size

Re: [PATCH v3] media: i2c: tvp514x: add OF support

2013-05-16 Thread Laurent Pinchart
Hi Prabhakar, On Thursday 16 May 2013 18:13:38 Prabhakar Lad wrote: > On Thu, May 16, 2013 at 5:40 PM, Laurent Pinchart wrote: > > Hi Prabhakar, > > [Snip] > > >> + > >> + pdata = devm_kzalloc(&client->dev, sizeof(*pdata), GFP_KERNEL); > >> + if (!pdata) > > > > I've started playing wit

Re: [PATCH v3] media: i2c: tvp514x: add OF support

2013-05-16 Thread Prabhakar Lad
Hi Laurent, Thanks for the review. On Thu, May 16, 2013 at 5:40 PM, Laurent Pinchart wrote: > Hi Prabhakar, > [Snip] >> + >> + pdata = devm_kzalloc(&client->dev, sizeof(*pdata), GFP_KERNEL); >> + if (!pdata) > > I've started playing with the V4L2 OF bindings, and realized that should > s

Re: [PATCH v3] media: i2c: tvp514x: add OF support

2013-05-16 Thread Laurent Pinchart
Hi Prabhakar, Thank you for the patch. On Tuesday 14 May 2013 16:30:36 Lad Prabhakar wrote: > From: Lad, Prabhakar > > add OF support for the tvp514x driver. Alongside this patch > removes unnecessary header file inclusion and sorts them alphabetically. > > Signed-off-by: Lad, Prabhakar > Cc:

[PATCH v3] media: i2c: tvp514x: add OF support

2013-05-14 Thread Lad Prabhakar
From: Lad, Prabhakar add OF support for the tvp514x driver. Alongside this patch removes unnecessary header file inclusion and sorts them alphabetically. Signed-off-by: Lad, Prabhakar Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Mauro Carvalho Chehab Cc: Guennadi Liakhovetski Cc: Sylwester Naw