Re: [PATCH v3] mfd: add STw481x driver

2013-09-25 Thread Linus Walleij
On Tue, Sep 24, 2013 at 3:56 PM, Lee Jones wrote: > On Mon, 23 Sep 2013, Linus Walleij wrote: > >> On Mon, Sep 23, 2013 at 10:44 AM, Lee Jones wrote: >> >> > I'm happy to change it myself, rather that asking you to resubmit. >> >> > >> >> > Which do you prefer? >> >> >> >> Pls fix it if you have

Re: [PATCH v3] mfd: add STw481x driver

2013-09-24 Thread Lee Jones
On Mon, 23 Sep 2013, Linus Walleij wrote: > On Mon, Sep 23, 2013 at 10:44 AM, Lee Jones wrote: > >> > I'm happy to change it myself, rather that asking you to resubmit. > >> > > >> > Which do you prefer? > >> > >> Pls fix it if you have time! > > > > Sorry, I should have been more clear. > > > >

Re: [PATCH v3] mfd: add STw481x driver

2013-09-23 Thread Linus Walleij
On Mon, Sep 23, 2013 at 10:44 AM, Lee Jones wrote: >> > I'm happy to change it myself, rather that asking you to resubmit. >> > >> > Which do you prefer? >> >> Pls fix it if you have time! > > Sorry, I should have been more clear. > > Which method do you prefer? The method where you fix it up whe

Re: [PATCH v3] mfd: add STw481x driver

2013-09-23 Thread Lee Jones
> > I'm happy to change it myself, rather that asking you to resubmit. > > > > Which do you prefer? > > Pls fix it if you have time! Sorry, I should have been more clear. Which method do you prefer? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for

Re: [PATCH v3] mfd: add STw481x driver

2013-09-23 Thread Linus Walleij
On Mon, Sep 23, 2013 at 10:05 AM, Lee Jones wrote: > Nit: > >> +static const struct i2c_device_id stw481x_id[] = { >> + { "stw481x", 0 }, >> + { } > > Where we have '{ }'. > >> +}; >> + >> +static const struct of_device_id stw481x_match[] = { >> + { .compatible = "st,stw4810", }, >> +

Re: [PATCH v3] mfd: add STw481x driver

2013-09-23 Thread Lee Jones
> This adds a driver for the STw481x PMICs found in the Nomadik > family of platforms. This one uses pure device tree probing. > Print some of the OTP registers on boot and register a regulator > MFD child. > > Signed-off-by: Linus Walleij > --- > ChangeLog v2->v3: > - Instead of using "dummy" as

[PATCH v3] mfd: add STw481x driver

2013-09-22 Thread Linus Walleij
This adds a driver for the STw481x PMICs found in the Nomadik family of platforms. This one uses pure device tree probing. Print some of the OTP registers on boot and register a regulator MFD child. Signed-off-by: Linus Walleij --- ChangeLog v2->v3: - Instead of using "dummy" as the unused device