Re: [PATCH v3] mm, memcg: fix reclaim deadlock with writeback

2018-12-14 Thread Michal Hocko
On Thu 13-12-18 17:04:00, Johannes Weiner wrote: [...] > Acked-by: Johannes Weiner Thanks! > Just one nit: > > > @@ -2993,6 +2993,17 @@ static vm_fault_t __do_fault(struct vm_fault *vmf) > > struct vm_area_struct *vma = vmf->vma; > > vm_fault_t ret; > > > > + /* > > +* Prealloca

Re: [PATCH v3] mm, memcg: fix reclaim deadlock with writeback

2018-12-13 Thread Liu Bo
On Thu, Dec 13, 2018 at 10:22:21AM +0100, Michal Hocko wrote: > From: Michal Hocko > > Liu Bo has experienced a deadlock between memcg (legacy) reclaim and the > ext4 writeback > task1: > [] wait_on_page_bit+0x82/0xa0 > [] shrink_page_list+0x907/0x960 > [] shrink_inactive_list+0x2c7/0x680 > [] sh

Re: [PATCH v3] mm, memcg: fix reclaim deadlock with writeback

2018-12-13 Thread Johannes Weiner
On Thu, Dec 13, 2018 at 10:22:21AM +0100, Michal Hocko wrote: > From: Michal Hocko > > Liu Bo has experienced a deadlock between memcg (legacy) reclaim and the > ext4 writeback > task1: > [] wait_on_page_bit+0x82/0xa0 > [] shrink_page_list+0x907/0x960 > [] shrink_inactive_list+0x2c7/0x680 > [] sh

Re: [PATCH v3] mm, memcg: fix reclaim deadlock with writeback

2018-12-13 Thread Michal Hocko
On Thu 13-12-18 13:41:47, Kirill A. Shutemov wrote: > On Thu, Dec 13, 2018 at 10:22:21AM +0100, Michal Hocko wrote: > > From: Michal Hocko > > > > Liu Bo has experienced a deadlock between memcg (legacy) reclaim and the > > ext4 writeback > > task1: > > [] wait_on_page_bit+0x82/0xa0 > > [] shrink

Re: [PATCH v3] mm, memcg: fix reclaim deadlock with writeback

2018-12-13 Thread Kirill A. Shutemov
On Thu, Dec 13, 2018 at 10:22:21AM +0100, Michal Hocko wrote: > From: Michal Hocko > > Liu Bo has experienced a deadlock between memcg (legacy) reclaim and the > ext4 writeback > task1: > [] wait_on_page_bit+0x82/0xa0 > [] shrink_page_list+0x907/0x960 > [] shrink_inactive_list+0x2c7/0x680 > [] sh

[PATCH v3] mm, memcg: fix reclaim deadlock with writeback

2018-12-13 Thread Michal Hocko
From: Michal Hocko Liu Bo has experienced a deadlock between memcg (legacy) reclaim and the ext4 writeback task1: [] wait_on_page_bit+0x82/0xa0 [] shrink_page_list+0x907/0x960 [] shrink_inactive_list+0x2c7/0x680 [] shrink_node_memcg+0x404/0x830 [] shrink_node+0xd8/0x300 [] do_try_to_free_pages+0x