Re: [PATCH v3] net: dsa: sja1105: prevent leaking memory

2019-09-19 Thread David Miller
From: Navid Emamdoost Date: Wed, 18 Sep 2019 15:34:06 -0500 > Fixes: 8aa9ebccae87 ("net: dsa: Introduce driver for NXP SJA1105 5-port > L2 switch") > > Fixes: 1a4c69406cc1 ("net: dsa: sja1105: Prevent PHY jabbering during > switch reset") Please: 1) Do not break Fixes: tags into multiples line

Re: [PATCH v3] net: dsa: sja1105: prevent leaking memory

2019-09-18 Thread Vladimir Oltean
On Wed, 18 Sep 2019 at 23:34, Navid Emamdoost wrote: > > In sja1105_static_config_upload, in two cases memory is leaked: when > static_config_buf_prepare_for_upload fails and when sja1105_inhibit_tx > fails. In both cases config_buf should be released. > > Fixes: 8aa9ebccae87 ("net: dsa: Introduce

[PATCH v3] net: dsa: sja1105: prevent leaking memory

2019-09-18 Thread Navid Emamdoost
In sja1105_static_config_upload, in two cases memory is leaked: when static_config_buf_prepare_for_upload fails and when sja1105_inhibit_tx fails. In both cases config_buf should be released. Fixes: 8aa9ebccae87 ("net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch") Fixes: 1a4c69406cc1 (