Re: [PATCH v3] net: macb: add support for high speed interface

2020-10-23 Thread Russell King - ARM Linux admin
On Fri, Oct 23, 2020 at 01:34:09PM +, Parshuram Raju Thombare wrote: > >Whenever the interface changes, we go through the full reconfiguration > >procedure that I've already outlined. This involves calling the > >mac_prepare() method which calls into mvpp2_mac_prepare() and its > >child

RE: [PATCH v3] net: macb: add support for high speed interface

2020-10-23 Thread Parshuram Raju Thombare
>Whenever the interface changes, we go through the full reconfiguration >procedure that I've already outlined. This involves calling the >mac_prepare() method which calls into mvpp2_mac_prepare() and its >child mvpp2__mac_prepare(). Ok, I misunderstood it as interface mode change between

Re: [PATCH v3] net: macb: add support for high speed interface

2020-10-23 Thread Russell King - ARM Linux admin
On Fri, Oct 23, 2020 at 10:59:42AM +, Parshuram Raju Thombare wrote: > Hi, > > I was trying to find out any ethernet driver where this issue of selecting > appropriate > pcs_ops due to phylink changing interface mode dynamically is handled. > But, apparently, so far only mvpp2 has adapted

RE: [PATCH v3] net: macb: add support for high speed interface

2020-10-23 Thread Parshuram Raju Thombare
Hi, I was trying to find out any ethernet driver where this issue of selecting appropriate pcs_ops due to phylink changing interface mode dynamically is handled. But, apparently, so far only mvpp2 has adapted pcs_ops. And even in mvpp2, it is not obvious how this case is handled. Also, apart

RE: [PATCH v3] net: macb: add support for high speed interface

2020-10-22 Thread Parshuram Raju Thombare
>If you're going to support pcs_ops for the 10GBASE-R mode, can you >also convert macb to use pcs_ops for the lower speed modes as well? Ok, I will add pcs_ops for low speed as well. In fact, having single pcs_ops and using check for interface type within each method of pcs_ops to decide

Re: [PATCH v3] net: macb: add support for high speed interface

2020-10-21 Thread Russell King - ARM Linux admin
On Wed, Oct 21, 2020 at 07:44:05PM +0200, Parshuram Thombare wrote: > This patch adds support for 10GBASE-R interface to the linux driver for > Cadence's ethernet controller. > This controller has separate MAC's and PCS'es for low and high speed paths. > High speed PCS supports 100M, 1G, 2.5G, 5G

[PATCH v3] net: macb: add support for high speed interface

2020-10-21 Thread Parshuram Thombare
This patch adds support for 10GBASE-R interface to the linux driver for Cadence's ethernet controller. This controller has separate MAC's and PCS'es for low and high speed paths. High speed PCS supports 100M, 1G, 2.5G, 5G and 10G through rate adaptation implementation. However, since it doesn't