Re: [PATCH v3] net: phy: fix uninitalized WOL parameters in phy_ethtool_get_wol

2014-03-15 Thread Sebastian Hesselbarth
On 03/13/2014 08:38 PM, David Miller wrote: From: Sebastian Hesselbarth Date: Wed, 12 Mar 2014 00:02:55 +0100 [...] To fix this, always zero relevant fields of struct ethtool_wolinfo regardless of .get_wol callback availability. [...] I'm starting to see this situation more clearly now, espe

Re: [PATCH v3] net: phy: fix uninitalized WOL parameters in phy_ethtool_get_wol

2014-03-14 Thread Sebastian Hesselbarth
On 03/13/2014 08:38 PM, David Miller wrote: From: Sebastian Hesselbarth Date: Wed, 12 Mar 2014 00:02:55 +0100 phy_ethtool_get_wol is a helper to get current WOL settings from a phy device. When using this helper on a PHY without .get_wol callback, struct ethtool_wolinfo is never set-up correct

Re: [PATCH v3] net: phy: fix uninitalized WOL parameters in phy_ethtool_get_wol

2014-03-13 Thread David Miller
From: Sebastian Hesselbarth Date: Wed, 12 Mar 2014 00:02:55 +0100 > phy_ethtool_get_wol is a helper to get current WOL settings from > a phy device. When using this helper on a PHY without .get_wol > callback, struct ethtool_wolinfo is never set-up correctly and > may contain misleading informati

Re: [PATCH v3] net: phy: fix uninitalized WOL parameters in phy_ethtool_get_wol

2014-03-13 Thread Sebastian Hesselbarth
On 03/13/2014 02:21 AM, Ben Hutchings wrote: On Wed, 2014-03-12 at 00:02 +0100, Sebastian Hesselbarth wrote: phy_ethtool_get_wol is a helper to get current WOL settings from a phy device. When using this helper on a PHY without .get_wol callback, struct ethtool_wolinfo is never set-up correctly

Re: [PATCH v3] net: phy: fix uninitalized WOL parameters in phy_ethtool_get_wol

2014-03-12 Thread Ben Hutchings
On Wed, 2014-03-12 at 00:02 +0100, Sebastian Hesselbarth wrote: > phy_ethtool_get_wol is a helper to get current WOL settings from > a phy device. When using this helper on a PHY without .get_wol > callback, struct ethtool_wolinfo is never set-up correctly and > may contain misleading information a

[PATCH v3] net: phy: fix uninitalized WOL parameters in phy_ethtool_get_wol

2014-03-11 Thread Sebastian Hesselbarth
phy_ethtool_get_wol is a helper to get current WOL settings from a phy device. When using this helper on a PHY without .get_wol callback, struct ethtool_wolinfo is never set-up correctly and may contain misleading information about WOL status. To fix this, always zero relevant fields of struct eth