Re: [PATCH v3] net: sched: Fix a possible null-pointer dereference in dequeue_func()

2019-08-05 Thread Eric Dumazet
On 7/29/19 7:23 PM, Cong Wang wrote: > On Mon, Jul 29, 2019 at 1:24 AM Jia-Ju Bai wrote: >> >> In dequeue_func(), there is an if statement on line 74 to check whether >> skb is NULL: >> if (skb) >> >> When skb is NULL, it is used on line 77: >> prefetch(&skb->end); >> >> Thus, a possibl

Re: [PATCH v3] net: sched: Fix a possible null-pointer dereference in dequeue_func()

2019-07-29 Thread Cong Wang
On Mon, Jul 29, 2019 at 1:24 AM Jia-Ju Bai wrote: > > In dequeue_func(), there is an if statement on line 74 to check whether > skb is NULL: > if (skb) > > When skb is NULL, it is used on line 77: > prefetch(&skb->end); > > Thus, a possible null-pointer dereference may occur. > > To fix th

Re: [PATCH v3] net: sched: Fix a possible null-pointer dereference in dequeue_func()

2019-07-29 Thread David Miller
From: Jia-Ju Bai Date: Mon, 29 Jul 2019 16:24:33 +0800 > In dequeue_func(), there is an if statement on line 74 to check whether > skb is NULL: > if (skb) > > When skb is NULL, it is used on line 77: > prefetch(&skb->end); > > Thus, a possible null-pointer dereference may occur. > > To

Re: [PATCH v3] net: sched: Fix a possible null-pointer dereference in dequeue_func()

2019-07-29 Thread Jiri Pirko
Mon, Jul 29, 2019 at 10:24:33AM CEST, baijiaju1...@gmail.com wrote: >In dequeue_func(), there is an if statement on line 74 to check whether >skb is NULL: >if (skb) > >When skb is NULL, it is used on line 77: >prefetch(&skb->end); > >Thus, a possible null-pointer dereference may occur. > >T

[PATCH v3] net: sched: Fix a possible null-pointer dereference in dequeue_func()

2019-07-29 Thread Jia-Ju Bai
In dequeue_func(), there is an if statement on line 74 to check whether skb is NULL: if (skb) When skb is NULL, it is used on line 77: prefetch(&skb->end); Thus, a possible null-pointer dereference may occur. To fix this bug, skb->end is used when skb is not NULL. This bug is found by a