Re: [PATCH v3] nfs: remove incorrect fallthrough label

2020-09-25 Thread Mark Brown
On Thu, Sep 24, 2020 at 02:11:59PM -0400, Anna Schumaker wrote: > On Thu, Sep 24, 2020 at 2:08 PM Joe Perches wrote: > > Real reason why not: > I'm planning to take this patch through the NFS tree for 5.10 (along > with the patch that apparently causes the problem). I didn't think it > was urgen

Re: [PATCH v3] nfs: remove incorrect fallthrough label

2020-09-24 Thread Anna Schumaker
On Thu, Sep 24, 2020 at 2:08 PM Joe Perches wrote: > > On Thu, 2020-09-24 at 10:40 -0700, Joe Perches wrote: > > On Thu, 2020-09-24 at 10:19 -0700, Nick Desaulniers wrote: > > > Hello maintainers, > > > Would you mind please picking up this patch? KernelCI has been > > > erroring for over a week

Re: [PATCH v3] nfs: remove incorrect fallthrough label

2020-09-24 Thread Joe Perches
On Thu, 2020-09-24 at 10:40 -0700, Joe Perches wrote: > On Thu, 2020-09-24 at 10:19 -0700, Nick Desaulniers wrote: > > Hello maintainers, > > Would you mind please picking up this patch? KernelCI has been > > erroring for over a week without it. > > As it's trivial and necessary, why not go throu

Re: [PATCH v3] nfs: remove incorrect fallthrough label

2020-09-24 Thread Gustavo A. R. Silva
On Thu, Sep 24, 2020 at 10:19:08AM -0700, Nick Desaulniers wrote: > Hello maintainers, > Would you mind please picking up this patch? KernelCI has been > erroring for over a week without it. > I can add this to my -next tree and queue it up for the next merge window. Thanks -- Gustavo

Re: [PATCH v3] nfs: remove incorrect fallthrough label

2020-09-24 Thread Joe Perches
On Thu, 2020-09-24 at 10:19 -0700, Nick Desaulniers wrote: > Hello maintainers, > Would you mind please picking up this patch? KernelCI has been > erroring for over a week without it. As it's trivial and necessary, why not go through Linus directly? https://lore.kernel.org/patchwork/patch/130754

Re: [PATCH v3] nfs: remove incorrect fallthrough label

2020-09-24 Thread Nick Desaulniers
Hello maintainers, Would you mind please picking up this patch? KernelCI has been erroring for over a week without it. On Thu, Sep 17, 2020 at 2:45 PM Nick Desaulniers wrote: > > There is no case after the default from which to fallthrough to. Clang > will error in this case (unhelpfully without

[PATCH v3] nfs: remove incorrect fallthrough label

2020-09-17 Thread Nick Desaulniers
There is no case after the default from which to fallthrough to. Clang will error in this case (unhelpfully without context, see link below) and GCC will with -Wswitch-unreachable. The previous commit should have just replaced the comment with a break statement. If we consider implicit fallthroug