[PATCH v3] nvmet: fix nvmet_execute_write_zeroes function

2018-04-02 Thread Rodrigo R. Galvao
When trying to issue write_zeroes command against TARGET with a 4K block size, it ends up hitting the following condition at __blkdev_issue_zeroout: if ((sector | nr_sects) & bs_mask) return -EINVAL; Causing the command to always fail. Considering we need to add 1 to get the

Re: [PATCH v3] nvmet: fix nvmet_execute_write_zeroes function

2018-04-02 Thread Keith Busch
Thanks, I've applied the patch with a simpler changelog explaining the bug.

Re: [PATCH v3] nvmet: fix nvmet_execute_write_zeroes function

2018-04-03 Thread Max Gurtovoy
On 4/2/2018 8:38 PM, Keith Busch wrote: Thanks, I've applied the patch with a simpler changelog explaining the bug. Thanks Rodrigo and Keith, I've tested with/w.o the patch and it works well (with the fix only). -Max. ___ Linux-nvme mailing li

Re: [PATCH v3] nvmet: fix nvmet_execute_write_zeroes function

2018-04-04 Thread Sagi Grimberg
Reviewed-by: Sagi Grimberg