Re: [PATCH v3] ovl: use a dedicated semaphore for dir upperfile caching

2021-01-21 Thread Icenowy Zheng
在 2021-01-21星期四的 09:07 +0100，Miklos Szeredi写道： > On Thu, Jan 21, 2021 at 4:43 AM Icenowy Zheng > wrote: > > > > 在 2021-01-20星期三的 11:20 +0100，Miklos Szeredi写道： > > > On Tue, Jan 05, 2021 at 08:47:41AM +0200, Amir Goldstein wrote: > > > > On Tue, Jan 5, 2021 at 2:36 AM Icenowy Zheng > > > >

Re: [PATCH v3] ovl: use a dedicated semaphore for dir upperfile caching

2021-01-21 Thread Miklos Szeredi
On Thu, Jan 21, 2021 at 4:43 AM Icenowy Zheng wrote: > > 在 2021-01-20星期三的 11:20 +0100，Miklos Szeredi写道： > > On Tue, Jan 05, 2021 at 08:47:41AM +0200, Amir Goldstein wrote: > > > On Tue, Jan 5, 2021 at 2:36 AM Icenowy Zheng > > > wrote: > > > > > > > > The function ovl_dir_real_file() currently

Re: [PATCH v3] ovl: use a dedicated semaphore for dir upperfile caching

2021-01-20 Thread Icenowy Zheng
在 2021-01-20星期三的 11:20 +0100，Miklos Szeredi写道： > On Tue, Jan 05, 2021 at 08:47:41AM +0200, Amir Goldstein wrote: > > On Tue, Jan 5, 2021 at 2:36 AM Icenowy Zheng > > wrote: > > > > > > The function ovl_dir_real_file() currently uses the semaphore of > > > the > > > inode to synchronize write to

Re: [PATCH v3] ovl: use a dedicated semaphore for dir upperfile caching

2021-01-20 Thread Amir Goldstein
On Wed, Jan 20, 2021 at 12:20 PM Miklos Szeredi wrote: > > On Tue, Jan 05, 2021 at 08:47:41AM +0200, Amir Goldstein wrote: > > On Tue, Jan 5, 2021 at 2:36 AM Icenowy Zheng wrote: > > > > > > The function ovl_dir_real_file() currently uses the semaphore of the > > > inode to synchronize write to

Re: [PATCH v3] ovl: use a dedicated semaphore for dir upperfile caching

2021-01-20 Thread Miklos Szeredi
On Tue, Jan 05, 2021 at 08:47:41AM +0200, Amir Goldstein wrote: > On Tue, Jan 5, 2021 at 2:36 AM Icenowy Zheng wrote: > > > > The function ovl_dir_real_file() currently uses the semaphore of the > > inode to synchronize write to the upperfile cache field. > > Although the inode lock is a rw_sem

Re: [PATCH v3] ovl: use a dedicated semaphore for dir upperfile caching

2021-01-16 Thread Amir Goldstein
On Tue, Jan 5, 2021 at 8:47 AM Amir Goldstein wrote: > > On Tue, Jan 5, 2021 at 2:36 AM Icenowy Zheng wrote: > > > > The function ovl_dir_real_file() currently uses the semaphore of the > > inode to synchronize write to the upperfile cache field. > > Although the inode lock is a rw_sem it is

Re: [PATCH v3] ovl: use a dedicated semaphore for dir upperfile caching

2021-01-04 Thread Amir Goldstein
On Tue, Jan 5, 2021 at 2:36 AM Icenowy Zheng wrote: > > The function ovl_dir_real_file() currently uses the semaphore of the > inode to synchronize write to the upperfile cache field. Although the inode lock is a rw_sem it is referred to as the "inode lock" and you also left semaphore in the

[PATCH v3] ovl: use a dedicated semaphore for dir upperfile caching

2021-01-04 Thread Icenowy Zheng
The function ovl_dir_real_file() currently uses the semaphore of the inode to synchronize write to the upperfile cache field. However, this function will get called by ovl_ioctl_set_flags(), which utilizes the inode semaphore too. In this case ovl_dir_real_file() will try to claim a lock that is