Re: [PATCH v3] panel: Use pr_err(...) rather than printk(KERN_ERR ...)

2012-07-11 Thread Toshiaki Yamane
Ryan-san, Joe-san, Thanks for your advice. I will try re-create the patch again. On Thu, Jul 12, 2012 at 2:43 PM, Joe Perches wrote: > On Thu, 2012-07-12 at 15:22 +1000, Ryan Mallon wrote: >> On 12/07/12 12:35, Toshiaki Yamane wrote: >> > This change is inspired by checkpatch. >> >> Your changel

Re: [PATCH v3] panel: Use pr_err(...) rather than printk(KERN_ERR ...)

2012-07-11 Thread Joe Perches
On Thu, 2012-07-12 at 15:22 +1000, Ryan Mallon wrote: > On 12/07/12 12:35, Toshiaki Yamane wrote: > > This change is inspired by checkpatch. > > Your changelog needs to describe all of the changes you are making. The > subject line only describes one. This patch is doing the following: > > - Con

Re: [PATCH v3] panel: Use pr_err(...) rather than printk(KERN_ERR ...)

2012-07-11 Thread Ryan Mallon
On 12/07/12 12:35, Toshiaki Yamane wrote: > This change is inspired by checkpatch. Your changelog needs to describe all of the changes you are making. The subject line only describes one. This patch is doing the following: - Converting printk(KERN_ERR to pr_err - Adding __func__ prefixes to pri

[PATCH v3] panel: Use pr_err(...) rather than printk(KERN_ERR ...)

2012-07-11 Thread Toshiaki Yamane
This change is inspired by checkpatch. Signed-off-by: Toshiaki Yamane --- drivers/staging/panel/panel.c | 42 +--- 1 files changed, 18 insertions(+), 24 deletions(-) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c index 7365089..a