Re: [PATCH v3] pata_pdc2027x: Remove unnecessary error check

2017-12-05 Thread Bartlomiej Zolnierkiewicz
On Saturday, November 25, 2017 03:49:49 PM Arvind Yadav wrote: > Here, The function pdc_hardware_init always return zero. So it is not > necessary to check its return value. Please fix pdc_adjust_pll() to return the error value instead. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R

Re: [PATCH v3] pata_pdc2027x: Remove unnecessary error check

2017-12-05 Thread Bartlomiej Zolnierkiewicz
On Saturday, November 25, 2017 03:49:49 PM Arvind Yadav wrote: > Here, The function pdc_hardware_init always return zero. So it is not > necessary to check its return value. Please fix pdc_adjust_pll() to return the error value instead. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R

[PATCH v3] pata_pdc2027x: Remove unnecessary error check

2017-11-25 Thread Arvind Yadav
Here, The function pdc_hardware_init always return zero. So it is not necessary to check its return value. Signed-off-by: Arvind Yadav --- changes in v2 : Make function return type 'void' instead of 'int. Add sapce between ':'. changes in

[PATCH v3] pata_pdc2027x: Remove unnecessary error check

2017-11-25 Thread Arvind Yadav
Here, The function pdc_hardware_init always return zero. So it is not necessary to check its return value. Signed-off-by: Arvind Yadav --- changes in v2 : Make function return type 'void' instead of 'int. Add sapce between ':'. changes in v3 : Fix the