Re: [PATCH v3] perf annotate/report: Remove hist__account_cycles from callback

2019-04-10 Thread Arnaldo Carvalho de Melo
Em Sat, Mar 16, 2019 at 05:16:17AM +0800, Jin Yao escreveu: > The hist__account_cycles is executed when the hist_iter__branch_callback > is called. But it looks it's not necessary. In hist__account_cycles, it > already walks on all branch entries. > > This patch moves the hist__account_cycles out

Re: [PATCH v3] perf annotate/report: Remove hist__account_cycles from callback

2019-03-19 Thread Andi Kleen
On Wed, Mar 20, 2019 at 08:35:17AM +0800, Jin, Yao wrote: > Nobody like this patch? :) > > In my test, for a 72MB perf.data (with LBR data), the perf annotate > processing speed: > > Before: 10.2s > After: 2.2s That's great! -Andi

Re: [PATCH v3] perf annotate/report: Remove hist__account_cycles from callback

2019-03-19 Thread Jin, Yao
Nobody like this patch? :) In my test, for a 72MB perf.data (with LBR data), the perf annotate processing speed: Before: 10.2s After: 2.2s Thanks Jin Yao On 3/16/2019 5:16 AM, Jin Yao wrote: The hist__account_cycles is executed when the hist_iter__branch_callback is called. But it looks it'

[PATCH v3] perf annotate/report: Remove hist__account_cycles from callback

2019-03-15 Thread Jin Yao
The hist__account_cycles is executed when the hist_iter__branch_callback is called. But it looks it's not necessary. In hist__account_cycles, it already walks on all branch entries. This patch moves the hist__account_cycles out of callback, now the data processing is much faster than before. Prev