Re: [PATCH v3] perf metricgroup: Fix uncore metric expressions

2020-09-17 Thread Ian Rogers
Should be ok. I cherry-picked the patch on to a local checkout of perf/urgent and sent as an in-reply-to here: https://lore.kernel.org/lkml/20200917190026.gb1426...@kernel.org/T/#m6c12d6a224540ed5f222e58fff9807f1cdc4238f Thanks, Ian On Thu, Sep 17, 2020 at 12:00 PM Arnaldo Carvalho de Melo wrote

Re: [PATCH v3] perf metricgroup: Fix uncore metric expressions

2020-09-17 Thread Arnaldo Carvalho de Melo
Em Fri, Sep 11, 2020 at 12:07:35PM +0900, Namhyung Kim escreveu: > On Fri, Sep 11, 2020 at 3:02 AM Ian Rogers wrote: > > v3. cleans up searching for the same event within metric_events to use a > > helper and avoids a redundant search. It uses a continue loop to > > make the search for sim

Re: [PATCH v3] perf metricgroup: Fix uncore metric expressions

2020-09-10 Thread Namhyung Kim
On Fri, Sep 11, 2020 at 3:02 AM Ian Rogers wrote: > > A metric like DRAM_BW_Use has on SkylakeX events uncore_imc/cas_count_read/ > and uncore_imc/case_count_write/. These events open 6 events per socket > with pmu names of uncore_imc_[0-5]. The current metric setup code in > find_evsel_group assu

[PATCH v3] perf metricgroup: Fix uncore metric expressions

2020-09-10 Thread Ian Rogers
A metric like DRAM_BW_Use has on SkylakeX events uncore_imc/cas_count_read/ and uncore_imc/case_count_write/. These events open 6 events per socket with pmu names of uncore_imc_[0-5]. The current metric setup code in find_evsel_group assumes one ID will map to 1 event to be recorded in metric_event