Re: [PATCH v3] perf pmu: Validate raw event with sysfs exported format bits

2021-03-09 Thread Jiri Olsa
On Tue, Mar 09, 2021 at 11:00:02AM +0800, Jin, Yao wrote: SNIP > > > if (format->value != PERF_PMU_FORMAT_VALUE_CONFIG) > > > continue; > > > > > > Is it right? > > > > sure, what I meant was to process only PERF_PMU_FORMAT_VALUE_CONFIG > > and then call break, because there's no need to iter

Re: [PATCH v3] perf pmu: Validate raw event with sysfs exported format bits

2021-03-08 Thread Jin, Yao
Hi Jiri, On 3/8/2021 9:14 PM, Jiri Olsa wrote: On Mon, Mar 08, 2021 at 08:57:49PM +0800, Jin, Yao wrote: Hi Jiri, On 3/8/2021 6:35 PM, Jiri Olsa wrote: On Mon, Mar 08, 2021 at 11:15:06AM +0800, Jin Yao wrote: SNIP diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c index 44ef28302fc

Re: [PATCH v3] perf pmu: Validate raw event with sysfs exported format bits

2021-03-08 Thread Jiri Olsa
On Mon, Mar 08, 2021 at 08:57:49PM +0800, Jin, Yao wrote: > Hi Jiri, > > On 3/8/2021 6:35 PM, Jiri Olsa wrote: > > On Mon, Mar 08, 2021 at 11:15:06AM +0800, Jin Yao wrote: > > > > SNIP > > > > > diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c > > > index 44ef28302fc7..03ab1e6d0418 100

Re: [PATCH v3] perf pmu: Validate raw event with sysfs exported format bits

2021-03-08 Thread Jin, Yao
Hi Jiri, On 3/8/2021 6:35 PM, Jiri Olsa wrote: On Mon, Mar 08, 2021 at 11:15:06AM +0800, Jin Yao wrote: SNIP diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c index 44ef28302fc7..03ab1e6d0418 100644 --- a/tools/perf/util/pmu.c +++ b/tools/perf/util/pmu.c @@ -1812,3 +1812,39 @@ int pe

Re: [PATCH v3] perf pmu: Validate raw event with sysfs exported format bits

2021-03-08 Thread Jiri Olsa
On Mon, Mar 08, 2021 at 11:15:06AM +0800, Jin Yao wrote: SNIP > diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c > index 44ef28302fc7..03ab1e6d0418 100644 > --- a/tools/perf/util/pmu.c > +++ b/tools/perf/util/pmu.c > @@ -1812,3 +1812,39 @@ int perf_pmu__caps_parse(struct perf_pmu *pmu)

[PATCH v3] perf pmu: Validate raw event with sysfs exported format bits

2021-03-07 Thread Jin Yao
A raw PMU event (eventsel+umask) in the form of rNNN is supported by perf but lacks of checking for the validity of raw encoding. For example, bit 16 and bit 17 are not valid on KBL but perf doesn't report warning when encoding with these bits. Before: # ./perf stat -e cpu/r031234/ -a -- sleep