Re: [PATCH v3] perf tools: avoid sample_reg_masks being const + weak

2019-10-10 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 09, 2019 at 04:07:37PM -0700, Ian Rogers escreveu: > On Tue, Oct 8, 2019 at 5:31 AM Jiri Olsa wrote: > > On Mon, Sep 30, 2019 at 05:36:23PM -0700, Ian Rogers wrote: > > > Being const + weak breaks with some compilers that constant-propagate > > > from the weak symbol. This behavior is

Re: [PATCH v3] perf tools: avoid sample_reg_masks being const + weak

2019-10-09 Thread Ian Rogers
On Tue, Oct 8, 2019 at 5:31 AM Jiri Olsa wrote: > > On Mon, Sep 30, 2019 at 05:36:23PM -0700, Ian Rogers wrote: > > Being const + weak breaks with some compilers that constant-propagate > > from the weak symbol. This behavior is outside of the specification, but > > in LLVM is chosen to match

Re: [PATCH v3] perf tools: avoid sample_reg_masks being const + weak

2019-10-08 Thread Jiri Olsa
On Mon, Sep 30, 2019 at 05:36:23PM -0700, Ian Rogers wrote: > Being const + weak breaks with some compilers that constant-propagate > from the weak symbol. This behavior is outside of the specification, but > in LLVM is chosen to match GCC's behavior. > > LLVM's implementation was set in this

Re: [PATCH v3] perf tools: avoid sample_reg_masks being const + weak

2019-10-07 Thread Nick Desaulniers
On Mon, Sep 30, 2019 at 5:36 PM 'Ian Rogers' via Clang Built Linux wrote: > > Being const + weak breaks with some compilers that constant-propagate > from the weak symbol. This behavior is outside of the specification, but > in LLVM is chosen to match GCC's behavior. > > LLVM's implementation was

[PATCH v3] perf tools: avoid sample_reg_masks being const + weak

2019-09-30 Thread Ian Rogers
Being const + weak breaks with some compilers that constant-propagate from the weak symbol. This behavior is outside of the specification, but in LLVM is chosen to match GCC's behavior. LLVM's implementation was set in this patch: