From: Kaixu Xia <kaixu...@tencent.com> The value of variable error is overwritten by the following call devm_request_threaded_irq() in phy_mdm6600_device_power_on(), actually we should return error when timed out powering up.
Reported-by: Tosk Robot <tencent_os_ro...@tencent.com> Signed-off-by: Kaixu Xia <kaixu...@tencent.com> --- drivers/phy/motorola/phy-mapphone-mdm6600.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c b/drivers/phy/motorola/phy-mapphone-mdm6600.c index 5172971f4c36..edbe227f47e8 100644 --- a/drivers/phy/motorola/phy-mapphone-mdm6600.c +++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c @@ -421,8 +421,8 @@ static int phy_mdm6600_device_power_on(struct phy_mdm6600 *ddata) dev_info(ddata->dev, "Powered up OK\n"); } else { ddata->enabled = false; - error = -ETIMEDOUT; dev_err(ddata->dev, "Timed out powering up\n"); + return -ETIMEDOUT; } /* Reconfigure mode1 GPIO as input for OOB wake */ -- 2.20.0