Re: [PATCH v3] pinctrl: aspeed: Fix ast2500 strap register write logic

2017-08-23 Thread Andrew Jeffery
On Wed, 2017-08-23 at 10:23 +0200, Linus Walleij wrote: > > On Wed, Aug 23, 2017 at 1:54 AM, Andrew Jeffery wrote: > > On Tue, 2017-08-22 at 14:52 +0200, Linus Walleij wrote: > > > > > > > > On Tue, Aug 15, 2017 at 6:21 PM, Yong Li > > > > > > > > wrote: > > > > On AST2500, the hardware strap re

Re: [PATCH v3] pinctrl: aspeed: Fix ast2500 strap register write logic

2017-08-23 Thread Linus Walleij
On Wed, Aug 23, 2017 at 1:54 AM, Andrew Jeffery wrote: > On Tue, 2017-08-22 at 14:52 +0200, Linus Walleij wrote: >> > On Tue, Aug 15, 2017 at 6:21 PM, Yong Li wrote: >> >> > On AST2500, the hardware strap register(SCU70) only accepts write ‘1’, >> > to clear it to ‘0’, must set bits(write ‘1’) t

Re: [PATCH v3] pinctrl: aspeed: Fix ast2500 strap register write logic

2017-08-22 Thread Andrew Jeffery
Hi Linus, On Tue, 2017-08-22 at 14:52 +0200, Linus Walleij wrote: > > On Tue, Aug 15, 2017 at 6:21 PM, Yong Li wrote: >  > > On AST2500, the hardware strap register(SCU70) only accepts write ‘1’, > > to clear it to ‘0’, must set bits(write  ‘1’) to SCU7C > >  > > Signed-off-by: Yong Li >  > Patc

Re: [PATCH v3] pinctrl: aspeed: Fix ast2500 strap register write logic

2017-08-22 Thread Linus Walleij
On Tue, Aug 15, 2017 at 6:21 PM, Yong Li wrote: > On AST2500, the hardware strap register(SCU70) only accepts write ‘1’, > to clear it to ‘0’, must set bits(write ‘1’) to SCU7C > > Signed-off-by: Yong Li Patch applied with Andrew's review/test tags. Yours, Linus Walleij

Re: [PATCH v3] pinctrl: aspeed: Fix ast2500 strap register write logic

2017-08-17 Thread Yong Li
Thanks Andrew for your thoughtful input. Let me send out another version :) 2017-08-16 20:19 GMT-07:00 Andrew Jeffery : > Hi Yong, > > On Wed, 2017-08-16 at 08:05 -0700, Yong Li wrote: >> Hi Andrew, >> >> Thanks for your review. I checked the patch before I sent out, but the >> tool did not report

Re: [PATCH v3] pinctrl: aspeed: Fix ast2500 strap register write logic

2017-08-16 Thread Andrew Jeffery
Hi Yong, On Wed, 2017-08-16 at 08:05 -0700, Yong Li wrote: > Hi Andrew, >  > Thanks for your review. I checked the patch before I sent out, but the > tool did not report any problems. Could you help to share your > checking commands? >  > scripts/checkpatch.pl > 0001-pinctrl-aspeed-Fix-ast2500-str

Re: [PATCH v3] pinctrl: aspeed: Fix ast2500 strap register write logic

2017-08-16 Thread Yong Li
Hi Andrew, Thanks for your review. I checked the patch before I sent out, but the tool did not report any problems. Could you help to share your checking commands? scripts/checkpatch.pl 0001-pinctrl-aspeed-Fix-ast2500-strap-register-write-logi.patch total: 0 errors, 0 warnings, 38 lines checked

Re: [PATCH v3] pinctrl: aspeed: Fix ast2500 strap register write logic

2017-08-16 Thread Andrew Jeffery
Hi Yong, On Wed, 2017-08-16 at 00:21 +0800, Yong Li wrote: > On AST2500, the hardware strap register(SCU70) only accepts write ‘1’, > to clear it to ‘0’, must set bits(write  ‘1’) to SCU7C > > Signed-off-by: Yong Li ./scripts/checkpatch.pl complains about DOS line-endings thoughout - you should

[PATCH v3] pinctrl: aspeed: Fix ast2500 strap register write logic

2017-08-15 Thread Yong Li
On AST2500, the hardware strap register(SCU70) only accepts write ‘1’, to clear it to ‘0’, must set bits(write ‘1’) to SCU7C Signed-off-by: Yong Li --- drivers/pinctrl/aspeed/pinctrl-aspeed.c | 19 +-- drivers/pinctrl/aspeed/pinctrl-aspeed.h | 1 + 2 files changed, 18 insertion