Re: [PATCH v3] pipe: Fix memory leaks in create_pipe_files()

On Thu, Oct 01, 2020 at 09:37:02AM -0400, Qian Cai wrote: > > Fixed by providing a dummy wath_queue_init() in !CONFIG_WATCH_QUEUE watch_queue_init(), that is > > case and by having failures of wath_queue_init() handled the same way

Re: [PATCH v3] pipe: Fix memory leaks in create_pipe_files()

On Thu, 2020-10-01 at 14:16 +0100, Al Viro wrote: > On Thu, Oct 01, 2020 at 08:50:55AM -0400, Qian Cai wrote: > > Calling pipe2() with O_NOTIFICATION_PIPE could results in memory leaks > > in an error path or CONFIG_WATCH_QUEUE=n. Plug them. > > [snip the copy of bug report] > > No objections on

Re: [PATCH v3] pipe: Fix memory leaks in create_pipe_files()

On Thu, Oct 01, 2020 at 08:50:55AM -0400, Qian Cai wrote: > Calling pipe2() with O_NOTIFICATION_PIPE could results in memory leaks > in an error path or CONFIG_WATCH_QUEUE=n. Plug them. [snip the copy of bug report] No objections on the patch itself, but commit message is just about unreadable.

[PATCH v3] pipe: Fix memory leaks in create_pipe_files()

Calling pipe2() with O_NOTIFICATION_PIPE could results in memory leaks in an error path or CONFIG_WATCH_QUEUE=n. Plug them. unreferenced object 0xc0141114a0d8 (size 992): comm "trinity-c61", pid 1353192, jiffies 4296255779 (age 25989.560s) hex dump (first 32 bytes): 80 11 00 00 e8 03