Re: [PATCH v3] platform/chrome: cros_ec_spi: Transfer messages at high priority

2019-04-12 Thread Enric Balletbo i Serra
Hi, On 12/4/19 3:27, Brian Norris wrote: > On Wed, Apr 3, 2019 at 1:32 PM Douglas Anderson wrote: >> +static int cros_ec_xfer_high_pri(struct cros_ec_device *ec_dev, >> +struct cros_ec_command *ec_msg, >> +cros_ec_xfer_fn_t fn) >>

Re: [PATCH v3] platform/chrome: cros_ec_spi: Transfer messages at high priority

2019-04-11 Thread Brian Norris
On Wed, Apr 3, 2019 at 1:32 PM Douglas Anderson wrote: > +static int cros_ec_xfer_high_pri(struct cros_ec_device *ec_dev, > +struct cros_ec_command *ec_msg, > +cros_ec_xfer_fn_t fn) > +{ > + struct cros_ec_xfer_work_params

Re: [PATCH v3] platform/chrome: cros_ec_spi: Transfer messages at high priority

2019-04-04 Thread Enric Balletbo i Serra
Hi Doug, Thanks for sending this patch upstream. On 3/4/19 23:19, Matthias Kaehlcke wrote: > On Wed, Apr 03, 2019 at 02:08:40PM -0700, Doug Anderson wrote: >> Hi, >> >> On Wed, Apr 3, 2019 at 2:04 PM Matthias Kaehlcke wrote: +static int cros_ec_xfer_high_pri(struct cros_ec_device *ec_dev,

Re: [PATCH v3] platform/chrome: cros_ec_spi: Transfer messages at high priority

2019-04-03 Thread Matthias Kaehlcke
On Wed, Apr 03, 2019 at 02:08:40PM -0700, Doug Anderson wrote: > Hi, > > On Wed, Apr 3, 2019 at 2:04 PM Matthias Kaehlcke wrote: > > > +static int cros_ec_xfer_high_pri(struct cros_ec_device *ec_dev, > > > > nit: the fact that a high priority workqueue is used is an > > implementation detail,

Re: [PATCH v3] platform/chrome: cros_ec_spi: Transfer messages at high priority

2019-04-03 Thread Doug Anderson
Hi, On Wed, Apr 3, 2019 at 2:04 PM Matthias Kaehlcke wrote: > > +static int cros_ec_xfer_high_pri(struct cros_ec_device *ec_dev, > > nit: the fact that a high priority workqueue is used is an > implementation detail, since the driver has no function to perform a > transfer with 'normal'/low

Re: [PATCH v3] platform/chrome: cros_ec_spi: Transfer messages at high priority

2019-04-03 Thread Matthias Kaehlcke
On Wed, Apr 03, 2019 at 01:31:37PM -0700, Douglas Anderson wrote: > The software running on the Chrome OS Embedded Controller (cros_ec) > handles SPI transfers in a bit of a wonky way. Specifically if the EC > sees too long of a delay in a SPI transfer it will give up and the > transfer will be

[PATCH v3] platform/chrome: cros_ec_spi: Transfer messages at high priority

2019-04-03 Thread Douglas Anderson
The software running on the Chrome OS Embedded Controller (cros_ec) handles SPI transfers in a bit of a wonky way. Specifically if the EC sees too long of a delay in a SPI transfer it will give up and the transfer will be counted as failed. Unfortunately the timeout is fairly short, though the