Re: [PATCH v3] platform/x86: add Gigabyte WMI temperature driver

2021-04-10 Thread Hans de Goede
Hi, On 4/10/21 5:15 PM, Guenter Roeck wrote: > On 4/10/21 7:40 AM, Thomas Weißschuh wrote: >> Changes since v1: >> * Incorporate feedback from Barnabás Pőcze >> * Use a WMI driver instead of a platform driver >> * Let the kernel manage the driver lifecycle >> * Fix errno/ACPI error

Re: [PATCH v3] platform/x86: add Gigabyte WMI temperature driver

2021-04-10 Thread Guenter Roeck
On 4/10/21 7:57 AM, Hans de Goede wrote: > Hi, > > On 4/10/21 4:40 PM, Thomas Weißschuh wrote: >> Changes since v1: >> * Incorporate feedback from Barnabás Pőcze >> * Use a WMI driver instead of a platform driver >> * Let the kernel manage the driver lifecycle >> * Fix errno/ACPI error

Re: [PATCH v3] platform/x86: add Gigabyte WMI temperature driver

2021-04-10 Thread Guenter Roeck
On 4/10/21 7:40 AM, Thomas Weißschuh wrote: > Changes since v1: > * Incorporate feedback from Barnabás Pőcze > * Use a WMI driver instead of a platform driver > * Let the kernel manage the driver lifecycle > * Fix errno/ACPI error confusion > * Fix resource cleanup > * Document reason

Re: [PATCH v3] platform/x86: add Gigabyte WMI temperature driver

2021-04-10 Thread Hans de Goede
Hi, On 4/10/21 4:40 PM, Thomas Weißschuh wrote: > Changes since v1: > * Incorporate feedback from Barnabás Pőcze > * Use a WMI driver instead of a platform driver > * Let the kernel manage the driver lifecycle > * Fix errno/ACPI error confusion > * Fix resource cleanup > * Document

[PATCH v3] platform/x86: add Gigabyte WMI temperature driver

2021-04-10 Thread Thomas Weißschuh
Changes since v1: * Incorporate feedback from Barnabás Pőcze * Use a WMI driver instead of a platform driver * Let the kernel manage the driver lifecycle * Fix errno/ACPI error confusion * Fix resource cleanup * Document reason for integer casting Changes since v2: * Style cleanups *