Re: [PATCH v3] platform: chrome: Add ChromeOS EC ISHTP driver

2019-04-15 Thread Enric Balletbo i Serra
Hi Rushikesh, Just few style comments and this can go throught the hid tree. On 7/4/19 14:10, Rushikesh S Kadam wrote: > This driver implements a slim layer to enable the ChromeOS > EC kernel stack (cros_ec) to communicate with ChromeOS EC > firmware running on the Intel Integrated Sensor Hub

Re: [PATCH v3] platform: chrome: Add ChromeOS EC ISHTP driver

2019-04-15 Thread Enric Balletbo i Serra
Hi, On 12/4/19 17:22, Srinivas Pandruvada wrote: > On Thu, 2019-04-11 at 15:54 +0200, Enric Balletbo i Serra wrote: >> Hi, >> >> On 11/4/19 13:10, Rushikesh S Kadam wrote: >>> Hi Enric, Srinivas >>> >>> On Thu, Apr 11, 2019 at 12:55:13PM +0200, Enric Balletbo i Serra >>> wrote: Hi,

Re: [PATCH v3] platform: chrome: Add ChromeOS EC ISHTP driver

2019-04-12 Thread Srinivas Pandruvada
On Thu, 2019-04-11 at 15:54 +0200, Enric Balletbo i Serra wrote: > Hi, > > On 11/4/19 13:10, Rushikesh S Kadam wrote: > > Hi Enric, Srinivas > > > > On Thu, Apr 11, 2019 at 12:55:13PM +0200, Enric Balletbo i Serra > > wrote: > > > Hi, > > > > > > On 10/4/19 17:31, Jett Rink wrote: > > > >

Re: [PATCH v3] platform: chrome: Add ChromeOS EC ISHTP driver

2019-04-11 Thread Enric Balletbo i Serra
Hi, On 11/4/19 13:10, Rushikesh S Kadam wrote: > Hi Enric, Srinivas > > On Thu, Apr 11, 2019 at 12:55:13PM +0200, Enric Balletbo i Serra wrote: >> Hi, >> >> On 10/4/19 17:31, Jett Rink wrote: >>> Reviewed-by: Jett Rink >>> Tested-by: Jett Rink >>> >>> >>> On Sun, Apr 7, 2019 at 6:10 AM

Re: [PATCH v3] platform: chrome: Add ChromeOS EC ISHTP driver

2019-04-11 Thread Rushikesh S Kadam
Hi Enric, Srinivas On Thu, Apr 11, 2019 at 12:55:13PM +0200, Enric Balletbo i Serra wrote: > Hi, > > On 10/4/19 17:31, Jett Rink wrote: > > Reviewed-by: Jett Rink > > Tested-by: Jett Rink > > > > > > On Sun, Apr 7, 2019 at 6:10 AM Rushikesh S Kadam > > wrote: > >> > >> This driver

Re: [PATCH v3] platform: chrome: Add ChromeOS EC ISHTP driver

2019-04-11 Thread Enric Balletbo i Serra
Hi, On 10/4/19 17:31, Jett Rink wrote: > Reviewed-by: Jett Rink > Tested-by: Jett Rink > > > On Sun, Apr 7, 2019 at 6:10 AM Rushikesh S Kadam > wrote: >> >> This driver implements a slim layer to enable the ChromeOS >> EC kernel stack (cros_ec) to communicate with ChromeOS EC >> firmware

Re: [PATCH v3] platform: chrome: Add ChromeOS EC ISHTP driver

2019-04-10 Thread Jett Rink
Reviewed-by: Jett Rink Tested-by: Jett Rink On Sun, Apr 7, 2019 at 6:10 AM Rushikesh S Kadam wrote: > > This driver implements a slim layer to enable the ChromeOS > EC kernel stack (cros_ec) to communicate with ChromeOS EC > firmware running on the Intel Integrated Sensor Hub (ISH). > > The

[PATCH v3] platform: chrome: Add ChromeOS EC ISHTP driver

2019-04-07 Thread Rushikesh S Kadam
This driver implements a slim layer to enable the ChromeOS EC kernel stack (cros_ec) to communicate with ChromeOS EC firmware running on the Intel Integrated Sensor Hub (ISH). The driver registers a ChromeOS EC MFD device to connect with cros_ec kernel stack (upper layer), and it registers a