Re: [PATCH v3] power: bq24735-charger: Request status GPIO with initial input setup

2016-09-02 Thread Paul Kocialkowski
Hi, Le vendredi 02 septembre 2016 à 17:27 +0200, Sebastian Reichel a écrit : > Hi Paul, > > This looks mostly fine now. I have a few more comments, that I > missed last time: Thanks for the review and for the useful suggestions. I have applied them to v4. > On Thu, Sep 01, 2016 at 11:27:00PM

Re: [PATCH v3] power: bq24735-charger: Request status GPIO with initial input setup

2016-09-02 Thread Paul Kocialkowski
Hi, Le vendredi 02 septembre 2016 à 17:27 +0200, Sebastian Reichel a écrit : > Hi Paul, > > This looks mostly fine now. I have a few more comments, that I > missed last time: Thanks for the review and for the useful suggestions. I have applied them to v4. > On Thu, Sep 01, 2016 at 11:27:00PM

Re: [PATCH v3] power: bq24735-charger: Request status GPIO with initial input setup

2016-09-02 Thread Sebastian Reichel
Hi Paul, This looks mostly fine now. I have a few more comments, that I missed last time: On Thu, Sep 01, 2016 at 11:27:00PM +0200, Paul Kocialkowski wrote: > This requests the status GPIO with initial input setup. it is required > to read the GPIO status at probe time and thus correctly avoid

Re: [PATCH v3] power: bq24735-charger: Request status GPIO with initial input setup

2016-09-02 Thread Sebastian Reichel
Hi Paul, This looks mostly fine now. I have a few more comments, that I missed last time: On Thu, Sep 01, 2016 at 11:27:00PM +0200, Paul Kocialkowski wrote: > This requests the status GPIO with initial input setup. it is required > to read the GPIO status at probe time and thus correctly avoid

[PATCH v3] power: bq24735-charger: Request status GPIO with initial input setup

2016-09-01 Thread Paul Kocialkowski
This requests the status GPIO with initial input setup. it is required to read the GPIO status at probe time and thus correctly avoid sending i2c messages when AC is not plugged. When requesting the GPIO without initial input setup, it always reads 0 which causes probe to fail as it assumes the

[PATCH v3] power: bq24735-charger: Request status GPIO with initial input setup

2016-09-01 Thread Paul Kocialkowski
This requests the status GPIO with initial input setup. it is required to read the GPIO status at probe time and thus correctly avoid sending i2c messages when AC is not plugged. When requesting the GPIO without initial input setup, it always reads 0 which causes probe to fail as it assumes the