Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-09 Thread Joe Perches
On Mon, 2012-07-09 at 16:32 -0700, Joe Perches wrote: > Then you've changed semantics and I think you need to > fix it. > > A dev_ call is not guaranteed to be a complete > message. > > There are dev_ and netdev_ calls > followed by pr_cont. > > Maybe these could be fixed up and then they could

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-09 Thread Joe Perches
On Tue, 2012-07-10 at 00:40 +0200, Kay Sievers wrote: > On Tue, Jul 10, 2012 at 12:29 AM, Joe Perches wrote: > > On Tue, 2012-07-10 at 00:10 +0200, Kay Sievers wrote: > >> On Mon, Jul 9, 2012 at 11:42 PM, Joe Perches wrote: > >> > On Sun, 2012-07-08 at 19:55 +0200, Kay Sievers wrote: > >> > > >>

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-09 Thread Kay Sievers
On Tue, Jul 10, 2012 at 12:29 AM, Joe Perches wrote: > On Tue, 2012-07-10 at 00:10 +0200, Kay Sievers wrote: >> On Mon, Jul 9, 2012 at 11:42 PM, Joe Perches wrote: >> > On Sun, 2012-07-08 at 19:55 +0200, Kay Sievers wrote: >> > >> >> At the same time the CPU#2 prints the same warning with a

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-09 Thread Michael Neuling
Greg Kroah-Hartman wrote: > On Sun, Jul 08, 2012 at 07:55:55PM +0200, Kay Sievers wrote: > > On Sat, 2012-07-07 at 07:04 +1000, Michael Neuling wrote: > > > Whole kmsg below. > > > > I guess I have an idea now what's going on. > > > > > 4,47,0;WARNING: at > > >

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-09 Thread Joe Perches
On Tue, 2012-07-10 at 00:10 +0200, Kay Sievers wrote: > On Mon, Jul 9, 2012 at 11:42 PM, Joe Perches wrote: > > On Sun, 2012-07-08 at 19:55 +0200, Kay Sievers wrote: > > > >> At the same time the CPU#2 prints the same warning with a continuation > >> line, but the buffer from CPU#1 can not be

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-09 Thread Kay Sievers
On Mon, Jul 9, 2012 at 11:42 PM, Joe Perches wrote: > On Sun, 2012-07-08 at 19:55 +0200, Kay Sievers wrote: > >> At the same time the CPU#2 prints the same warning with a continuation >> line, but the buffer from CPU#1 can not be flushed to the console, nor >> can the continuation line printk()s

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-09 Thread Joe Perches
On Sun, 2012-07-08 at 19:55 +0200, Kay Sievers wrote: > At the same time the CPU#2 prints the same warning with a continuation > line, but the buffer from CPU#1 can not be flushed to the console, nor > can the continuation line printk()s from CPU#2 be merged at this point. > The consoles are

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-09 Thread Joe Perches
On Mon, 2012-07-09 at 10:09 -0700, Greg Kroah-Hartman wrote: > is it ok if we > just merge this in 3.6-rc1 and backport it to 3.5.1 if it looks ok > there? I'd prefer it get accepted now so that refactoring the printk subsystem could occur for 3.6. Another option would be to revert all Kay's

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-09 Thread Greg Kroah-Hartman
On Sun, Jul 08, 2012 at 07:55:55PM +0200, Kay Sievers wrote: > On Sat, 2012-07-07 at 07:04 +1000, Michael Neuling wrote: > > Whole kmsg below. > > I guess I have an idea now what's going on. > > > 4,47,0;WARNING: at > > /scratch/mikey/src/linux-ozlabs/arch/powerpc/sysdev/xics/xics-common.c:105

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-09 Thread Greg Kroah-Hartman
On Sun, Jul 08, 2012 at 07:55:55PM +0200, Kay Sievers wrote: On Sat, 2012-07-07 at 07:04 +1000, Michael Neuling wrote: Whole kmsg below. I guess I have an idea now what's going on. 4,47,0;WARNING: at /scratch/mikey/src/linux-ozlabs/arch/powerpc/sysdev/xics/xics-common.c:105

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-09 Thread Joe Perches
On Mon, 2012-07-09 at 10:09 -0700, Greg Kroah-Hartman wrote: is it ok if we just merge this in 3.6-rc1 and backport it to 3.5.1 if it looks ok there? I'd prefer it get accepted now so that refactoring the printk subsystem could occur for 3.6. Another option would be to revert all Kay's

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-09 Thread Joe Perches
On Sun, 2012-07-08 at 19:55 +0200, Kay Sievers wrote: At the same time the CPU#2 prints the same warning with a continuation line, but the buffer from CPU#1 can not be flushed to the console, nor can the continuation line printk()s from CPU#2 be merged at this point. The consoles are still

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-09 Thread Kay Sievers
On Mon, Jul 9, 2012 at 11:42 PM, Joe Perches j...@perches.com wrote: On Sun, 2012-07-08 at 19:55 +0200, Kay Sievers wrote: At the same time the CPU#2 prints the same warning with a continuation line, but the buffer from CPU#1 can not be flushed to the console, nor can the continuation line

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-09 Thread Joe Perches
On Tue, 2012-07-10 at 00:10 +0200, Kay Sievers wrote: On Mon, Jul 9, 2012 at 11:42 PM, Joe Perches j...@perches.com wrote: On Sun, 2012-07-08 at 19:55 +0200, Kay Sievers wrote: At the same time the CPU#2 prints the same warning with a continuation line, but the buffer from CPU#1 can not

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-09 Thread Michael Neuling
Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Sun, Jul 08, 2012 at 07:55:55PM +0200, Kay Sievers wrote: On Sat, 2012-07-07 at 07:04 +1000, Michael Neuling wrote: Whole kmsg below. I guess I have an idea now what's going on. 4,47,0;WARNING: at

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-09 Thread Kay Sievers
On Tue, Jul 10, 2012 at 12:29 AM, Joe Perches j...@perches.com wrote: On Tue, 2012-07-10 at 00:10 +0200, Kay Sievers wrote: On Mon, Jul 9, 2012 at 11:42 PM, Joe Perches j...@perches.com wrote: On Sun, 2012-07-08 at 19:55 +0200, Kay Sievers wrote: At the same time the CPU#2 prints the same

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-09 Thread Joe Perches
On Tue, 2012-07-10 at 00:40 +0200, Kay Sievers wrote: On Tue, Jul 10, 2012 at 12:29 AM, Joe Perches j...@perches.com wrote: On Tue, 2012-07-10 at 00:10 +0200, Kay Sievers wrote: On Mon, Jul 9, 2012 at 11:42 PM, Joe Perches j...@perches.com wrote: On Sun, 2012-07-08 at 19:55 +0200, Kay

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-09 Thread Joe Perches
On Mon, 2012-07-09 at 16:32 -0700, Joe Perches wrote: Then you've changed semantics and I think you need to fix it. A dev_level call is not guaranteed to be a complete message. There are dev_level and netdev_level calls followed by pr_cont. Maybe these could be fixed up and then they

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-08 Thread Kay Sievers
On Sat, 2012-07-07 at 07:04 +1000, Michael Neuling wrote: > Whole kmsg below. I guess I have an idea now what's going on. > 4,47,0;WARNING: at > /scratch/mikey/src/linux-ozlabs/arch/powerpc/sysdev/xics/xics-common.c:105 > 4,51,0;MSR: 90021032 CR: 2442 XER: 2200 > 4,54,0;TASK

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-08 Thread Kay Sievers
On Sat, 2012-07-07 at 07:04 +1000, Michael Neuling wrote: Whole kmsg below. I guess I have an idea now what's going on. 4,47,0;WARNING: at /scratch/mikey/src/linux-ozlabs/arch/powerpc/sysdev/xics/xics-common.c:105 4,51,0;MSR: 90021032 SF,HV,ME,IR,DR,RI CR: 2442 XER: 2200

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-06 Thread Michael Neuling
Kay Sievers wrote: > On Fri, Jul 6, 2012 at 12:46 PM, Kay Sievers wrote: > > On Fri, Jul 6, 2012 at 5:47 AM, Michael Neuling wrote: > > > >>> 4,89,24561;NIP: c0048164 LR: c0048160 CTR: > >>> > >>> 4,90,24576;REGS: c0007e59fb50 TRAP: 0700 Tainted: G

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-06 Thread Kay Sievers
On Fri, Jul 6, 2012 at 12:46 PM, Kay Sievers wrote: > On Fri, Jul 6, 2012 at 5:47 AM, Michael Neuling wrote: > >>> 4,89,24561;NIP: c0048164 LR: c0048160 CTR: >>> 4,90,24576;REGS: c0007e59fb50 TRAP: 0700 Tainted: GW >>> (3.5.0-rc4-mikey) >>>

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-06 Thread Kay Sievers
On Fri, Jul 6, 2012 at 12:46 PM, Kay Sievers k...@vrfy.org wrote: On Fri, Jul 6, 2012 at 5:47 AM, Michael Neuling mi...@neuling.org wrote: 4,89,24561;NIP: c0048164 LR: c0048160 CTR: 4,90,24576;REGS: c0007e59fb50 TRAP: 0700 Tainted: GW

Re: [PATCH v3] printk: Have printk() never buffer its data

2012-07-06 Thread Michael Neuling
Kay Sievers k...@vrfy.org wrote: On Fri, Jul 6, 2012 at 12:46 PM, Kay Sievers k...@vrfy.org wrote: On Fri, Jul 6, 2012 at 5:47 AM, Michael Neuling mi...@neuling.org wrote: 4,89,24561;NIP: c0048164 LR: c0048160 CTR: 4,90,24576;REGS: c0007e59fb50