Re: [PATCH v3] ptp: mark symbols static where possible

2020-09-18 Thread kernel test robot
Hi Herrington, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.9-rc5 next-20200918] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as docu

Re: [PATCH v3] ptp: mark symbols static where possible

2020-09-18 Thread Richard Cochran
On Fri, Sep 18, 2020 at 06:09:43PM +0800, Herrington wrote: > diff --git a/include/linux/ptp_clock_kernel.h > b/include/linux/ptp_clock_kernel.h > index d3e8ba5c7125..5db4b8891b22 100644 > --- a/include/linux/ptp_clock_kernel.h > +++ b/include/linux/ptp_clock_kernel.h > @@ -307,4 +307,13 @@ static

[PATCH v3] ptp: mark symbols static where possible

2020-09-18 Thread Herrington
We get 1 warning when building kernel with W=1: drivers/ptp/ptp_pch.c:182:5: warning: no previous prototype for ‘pch_ch_control_read’ [-Wmissing-prototypes] u32 pch_ch_control_read(struct pci_dev *pdev) drivers/ptp/ptp_pch.c:193:6: warning: no previous prototype for ‘pch_ch_control_write’ [-Wmis