Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-10 Thread Oscar Salvador
On Sat, Aug 11, 2018 at 12:25:39AM +1000, Rashmica Gupta wrote: > On Fri, Aug 10, 2018 at 11:00 PM, Michal Hocko wrote: > > On Fri 10-08-18 16:55:40, Rashmica Gupta wrote: > > [...] > >> Most memory hotplug/hotremove seems to be block or section based, and > >> always adds and removes memory at

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-10 Thread Oscar Salvador
On Sat, Aug 11, 2018 at 12:25:39AM +1000, Rashmica Gupta wrote: > On Fri, Aug 10, 2018 at 11:00 PM, Michal Hocko wrote: > > On Fri 10-08-18 16:55:40, Rashmica Gupta wrote: > > [...] > >> Most memory hotplug/hotremove seems to be block or section based, and > >> always adds and removes memory at

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-10 Thread Rashmica Gupta
On Fri, Aug 10, 2018 at 11:00 PM, Michal Hocko wrote: > On Fri 10-08-18 16:55:40, Rashmica Gupta wrote: > [...] >> Most memory hotplug/hotremove seems to be block or section based, and >> always adds and removes memory at the same place. > > Yes and that is hard wired to the memory hotplug code.

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-10 Thread Rashmica Gupta
On Fri, Aug 10, 2018 at 11:00 PM, Michal Hocko wrote: > On Fri 10-08-18 16:55:40, Rashmica Gupta wrote: > [...] >> Most memory hotplug/hotremove seems to be block or section based, and >> always adds and removes memory at the same place. > > Yes and that is hard wired to the memory hotplug code.

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-10 Thread Michal Hocko
On Fri 10-08-18 16:55:40, Rashmica Gupta wrote: [...] > Most memory hotplug/hotremove seems to be block or section based, and > always adds and removes memory at the same place. Yes and that is hard wired to the memory hotplug code. It is not easy to make it work outside of section units

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-10 Thread Michal Hocko
On Fri 10-08-18 16:55:40, Rashmica Gupta wrote: [...] > Most memory hotplug/hotremove seems to be block or section based, and > always adds and removes memory at the same place. Yes and that is hard wired to the memory hotplug code. It is not easy to make it work outside of section units

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-10 Thread Oscar Salvador
On Thu, Aug 09, 2018 at 12:54:09PM +1000, Rashmica Gupta wrote: > When hot-removing memory release_mem_region_adjustable() splits > iomem resources if they are not the exact size of the memory being > hot-deleted. Adding this memory back to the kernel adds a new > resource. > > Eg a node has

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-10 Thread Oscar Salvador
On Thu, Aug 09, 2018 at 12:54:09PM +1000, Rashmica Gupta wrote: > When hot-removing memory release_mem_region_adjustable() splits > iomem resources if they are not the exact size of the memory being > hot-deleted. Adding this memory back to the kernel adds a new > resource. > > Eg a node has

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-10 Thread Vlastimil Babka
On 08/10/2018 08:55 AM, Rashmica Gupta wrote: > On Fri, Aug 10, 2018 at 11:12 AM, Andrew Morton > wrote: >> >> What is the end-user impact of this patch? >> > > Only architectures/setups that allow the user to remove and add memory of > different sizes or different start addresses from the

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-10 Thread Vlastimil Babka
On 08/10/2018 08:55 AM, Rashmica Gupta wrote: > On Fri, Aug 10, 2018 at 11:12 AM, Andrew Morton > wrote: >> >> What is the end-user impact of this patch? >> > > Only architectures/setups that allow the user to remove and add memory of > different sizes or different start addresses from the

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-10 Thread Rashmica Gupta
On Fri, Aug 10, 2018 at 11:12 AM, Andrew Morton wrote: > On Thu, 9 Aug 2018 12:54:09 +1000 Rashmica Gupta > wrote: > >> When hot-removing memory release_mem_region_adjustable() splits >> iomem resources if they are not the exact size of the memory being >> hot-deleted. Adding this memory back

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-10 Thread Rashmica Gupta
On Fri, Aug 10, 2018 at 11:12 AM, Andrew Morton wrote: > On Thu, 9 Aug 2018 12:54:09 +1000 Rashmica Gupta > wrote: > >> When hot-removing memory release_mem_region_adjustable() splits >> iomem resources if they are not the exact size of the memory being >> hot-deleted. Adding this memory back

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-09 Thread Andrew Morton
On Thu, 9 Aug 2018 12:54:09 +1000 Rashmica Gupta wrote: > When hot-removing memory release_mem_region_adjustable() splits > iomem resources if they are not the exact size of the memory being > hot-deleted. Adding this memory back to the kernel adds a new > resource. > > Eg a node has memory

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-09 Thread Andrew Morton
On Thu, 9 Aug 2018 12:54:09 +1000 Rashmica Gupta wrote: > When hot-removing memory release_mem_region_adjustable() splits > iomem resources if they are not the exact size of the memory being > hot-deleted. Adding this memory back to the kernel adds a new > resource. > > Eg a node has memory

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-09 Thread Mike Rapoport
On Thu, Aug 09, 2018 at 12:54:09PM +1000, Rashmica Gupta wrote: > When hot-removing memory release_mem_region_adjustable() splits > iomem resources if they are not the exact size of the memory being > hot-deleted. Adding this memory back to the kernel adds a new > resource. > > Eg a node has

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-09 Thread Mike Rapoport
On Thu, Aug 09, 2018 at 12:54:09PM +1000, Rashmica Gupta wrote: > When hot-removing memory release_mem_region_adjustable() splits > iomem resources if they are not the exact size of the memory being > hot-deleted. Adding this memory back to the kernel adds a new > resource. > > Eg a node has

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-09 Thread Vlastimil Babka
On 08/09/2018 04:54 AM, Rashmica Gupta wrote: > When hot-removing memory release_mem_region_adjustable() splits > iomem resources if they are not the exact size of the memory being > hot-deleted. Adding this memory back to the kernel adds a new > resource. > > Eg a node has memory 0x0 -

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-09 Thread Vlastimil Babka
On 08/09/2018 04:54 AM, Rashmica Gupta wrote: > When hot-removing memory release_mem_region_adjustable() splits > iomem resources if they are not the exact size of the memory being > hot-deleted. Adding this memory back to the kernel adds a new > resource. > > Eg a node has memory 0x0 -

[PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-08 Thread Rashmica Gupta
When hot-removing memory release_mem_region_adjustable() splits iomem resources if they are not the exact size of the memory being hot-deleted. Adding this memory back to the kernel adds a new resource. Eg a node has memory 0x0 - 0xf. Offlining and hot-removing 1GB from 0xf4000

[PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-08 Thread Rashmica Gupta
When hot-removing memory release_mem_region_adjustable() splits iomem resources if they are not the exact size of the memory being hot-deleted. Adding this memory back to the kernel adds a new resource. Eg a node has memory 0x0 - 0xf. Offlining and hot-removing 1GB from 0xf4000