Re: [PATCH v3] rtc: Add tracepoints for RTC system

2018-02-13 Thread Alexandre Belloni
On 14/12/2017 at 13:31:43 +0800, Baolin Wang wrote: > It will be more helpful to add some tracepoints to track RTC actions when > debugging RTC driver. Below sample is that we set/read the RTC time, then > set 2 alarms, so we can see the trace logs: > > set/read RTC time: > kworker/0:1-67 [000] 21

Re: [PATCH v3] rtc: Add tracepoints for RTC system

2017-12-14 Thread Alexandre Belloni
Hi Steve, (Writing from my @kernel.org email to ensure you receive it) On 14/12/2017 at 12:49:12 -0500, Steven Rostedt wrote: > On Thu, 14 Dec 2017 13:31:43 +0800 > Baolin Wang wrote: > > > > @@ -53,6 +56,8 @@ int rtc_read_time(struct rtc_device *rtc, struct rtc_time > > *tm) > > > > er

Re: [PATCH v3] rtc: Add tracepoints for RTC system

2017-12-14 Thread Steven Rostedt
On Thu, 14 Dec 2017 13:31:43 +0800 Baolin Wang wrote: > @@ -53,6 +56,8 @@ int rtc_read_time(struct rtc_device *rtc, struct rtc_time > *tm) > > err = __rtc_read_time(rtc, tm); > mutex_unlock(&rtc->ops_lock); > + > + trace_rtc_read_time(rtc_tm_to_time64(tm), err); There's a pos

[PATCH v3] rtc: Add tracepoints for RTC system

2017-12-13 Thread Baolin Wang
It will be more helpful to add some tracepoints to track RTC actions when debugging RTC driver. Below sample is that we set/read the RTC time, then set 2 alarms, so we can see the trace logs: set/read RTC time: kworker/0:1-67 [000] 21.814245: rtc_set_time: UTC (1510301580) (0) kworker/0:1-67 [000]